Regression in PartDesign mirror

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
user1234
Veteran
Posts: 3339
Joined: Mon Jul 11, 2016 5:08 pm

Re: Regression in PartDesign mirror

Post by user1234 »

works on:

Code: Select all

OS: Debian GNU/Linux 11 (bullseye) (X-Cinnamon/lightdm-xsession)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.20.Unknown --> 0.20.24409
Build type: Unknown
Python version: 3.9.2
Qt version: 5.15.2
Coin version: 4.0.0
OCC version: 7.5.1
Locale: English/United States (en_US)
So the issue is between 24553 - 24409

Greetings
user1234
Attachments
0.png
0.png (143.24 KiB) Viewed 1629 times
user1234
Veteran
Posts: 3339
Joined: Mon Jul 11, 2016 5:08 pm

Re: Regression in PartDesign mirror

Post by user1234 »

It seems it is between 24416 and 24419. Here are worked on the transformation on mirrors in mirrors in PartDesign.

Greetings
user1234
user1234
Veteran
Posts: 3339
Joined: Mon Jul 11, 2016 5:08 pm

Re: Regression in PartDesign mirror

Post by user1234 »

src/Mod/PartDesign/App/FeatureTransformed.cpp
between Line 299 and 300:

Code: Select all

++t; // Skip first transformation, which is always the identity transformation
The line as removed. When i add them it works. The question is, if i add them if any other regression will appear. But today my time is over.

Greetings
user1234
chrisb
Veteran
Posts: 53924
Joined: Tue Mar 17, 2015 9:14 am

Re: Regression in PartDesign mirror

Post by chrisb »

chennes wrote: Mon Jul 05, 2021 2:00 pm What revision do you want me to test?
Sorry, with all these versions flying around things became rather obscured than clear. I have tested with the latest precompiled version and it still shows the issue. It would be kind if you look at the current master. The issue is described in the first post of this topic: Load the file
mirror_fills_pocket.FCStd and recompute it. It should show the small cubic cutout, but instead it is filled.

OS: macOS 10.16
Word size of FreeCAD: 64-bit
Version: 0.20.25176 (Git)
Build type: Release
Branch: master
Hash: 909dfa7036f9fd36bbd3acee2a5dee161d2819fb
Python version: 3.9.5
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.5.2
Locale: C/Default (C)

Edit: Had the tab open for quite some time and thus missed user1234's very helpful investigations.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Regression in PartDesign mirror

Post by uwestoehr »

The bug should now be fixed with commits
https://github.com/FreeCAD/FreeCAD/commit/9fe1f56824
and
https://github.com/FreeCAD/FreeCAD/comm ... 54135ccfe2

For those interested in the technical details of the bug, see https://forum.freecadweb.org/viewtopic.php?f=10&t=60054
chrisb
Veteran
Posts: 53924
Joined: Tue Mar 17, 2015 9:14 am

Re: Regression in PartDesign mirror

Post by chrisb »

Thanks!
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Regression in PartDesign mirror

Post by uwestoehr »

chrisb wrote: Wed Sep 15, 2021 5:52 pmThanks!
Can you please mark this thread therefore as "[fixed]"
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Regression in PartDesign mirror

Post by wmayer »

uwestoehr wrote: Wed Sep 15, 2021 2:56 pm The bug should now be fixed with commits
https://github.com/FreeCAD/FreeCAD/commit/9fe1f56824
and
https://github.com/FreeCAD/FreeCAD/comm ... 54135ccfe2

For those interested in the technical details of the bug, see https://forum.freecadweb.org/viewtopic.php?f=10&t=60054
This has nothing to do with the other bug. The other bug was only about loading an older project where certain renamed or retyped properties couldn't be read-in.
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Regression in PartDesign mirror

Post by wmayer »

chrisb wrote: Wed Sep 15, 2021 5:52 pmThanks!
If not yet done please open a bug report and post its ID here.

I can reproduce the problem also with OCC 7.3.0
user1234
Veteran
Posts: 3339
Joined: Mon Jul 11, 2016 5:08 pm

Re: Regression in PartDesign mirror

Post by user1234 »

I can not reproduce it anymore.

Code: Select all

OS: Debian GNU/Linux 11 (bullseye) (X-Cinnamon/lightdm-xsession)
Word size of FreeCAD: 64-bit
Version: 0.20.25723 (Git)
Build type: Release
Branch: master
Hash: 9fe1f568246dd63573e6d12aaffbcd8ebaf7cf51
Python version: 3.9.2
Qt version: 5.15.2
Coin version: 4.0.0
OCC version: 7.5.3
Locale: English/United States (en_US)
But it is hard to believe that it is OCCT related.

Greetings
user1234
Post Reply