[solved] (Dangerous) behavior from the sketcher

[Syres]

I submitted a PR

It passes my Hexagon test, thanks. That exclude tangent code has been in there for so many years I'm sure it's been forgotten about, but don't worry if it breaks something you'll be the first to know

[openBrain]

Yellow highlight is not enough. The small symbols are important.

Some more words on this.
Highlighting and auto-constraint symbols are really 2 separate processes.
Highlight comes as soon as something "eligible" is found inside the pick radius.
Cursor symbols only come when an auto-constraint suggestion exists.

We tend to mix both because there is (AFAIK) no case where no pertinent constraint exists between 2 types of geometry.
Except this is what happened there because tangent (which is IMO the correct constraint) was internally rejected for some obscure reason.

[chrisb]

i think the solution is very good. Many thanks

+1

[M4x]

I like it, thank you!

[thomas-neemann]

here is something else that could be improved upon.

this is not dangerous because it generates an error message, but it could be solved similarly in my opinion.

video from a step import with the attempt to reference a circle.

https://www.youtube.com/watch?v=2DRn_RUXgu4

sketcher.FCStd

(4.83 KiB) Downloaded 35 times

[chrisb]

but it could be solved similarly in my opinion.

I don't think so, because it's the opposite of what openBrain just implemented: In most cases we want a tangent if only edges are involved. And only in this very special case it leads to a problem and what we really want is an equality constraint.

[thomas-neemann]

but it could be solved similarly in my opinion.

I don't think so, because it's the opposite of what openBrain just implemented: In most cases we want a tangent if only edges are involved. And only in this very special case it leads to a problem.

ok

[openBrain]

here is something else that could be improved upon.

this is not dangerous because it generates an error message, but it could be solved similarly in my opinion.

video from a step import with the attempt to reference a circle.

@chrisb said it all. This is a corner case where we have to rely on human brain to process it correctly.

[thomas-neemann]

OK. if it is the same with circle 3 pts and an error message appears, it is harmless. Thank you

[GeneFC]

This is a corner case where we have to rely on human brain to process it correctly.

Open or closed brain?

Gene