Sheet Metal Workbench

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
janifr
Posts: 9
Joined: Sat Oct 30, 2021 2:05 pm

Re: Sheet Metal Workbench

Post by janifr »

-alex- wrote: Mon Nov 08, 2021 10:45 pm But Unfold_Sketch_bends is empty now, only new Bendlines object is visible.
This is now fixed https://github.com/janifr/FreeCAD_Sheet ... db144b4dc1

Edit:
Fixed the other issues as well. Can you try if it works?
https://github.com/janifr/FreeCAD_Sheet ... nfolder.py

TO DO:
-If possible, place new objects in separate container so that they don't mess up the treeview
-Modify bend label placements so that they don't overlap if they are close to each other, possibly in the middle of the bend line
User avatar
-alex-
Veteran
Posts: 1856
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: Sheet Metal Workbench

Post by -alex- »

janifr wrote: Tue Nov 09, 2021 9:16 am
-alex- wrote: Mon Nov 08, 2021 10:45 pm But Unfold_Sketch_bends is empty now, only new Bendlines object is visible.
This is now fixed https://github.com/janifr/FreeCAD_Sheet ... db144b4dc1
sorry but I see no effect, Unfold_Sketch_bends is still empty.
Edit:
Fixed the other issues as well. Can you try if it works?
https://github.com/janifr/FreeCAD_Sheet ... nfolder.py
You added angle value in code, thanks for that, but angle value is still missing in bendtable. BTW K-factor in bendtable still seems wrong to me.
Other users can give it a try, any comments are welcome.

TO DO:
-If possible, place new objects in separate container so that they don't mess up the treeview
+1
-Modify bend label placements so that they don't overlap if they are close to each other, possibly in the middle of the bend line
+1 , IMHO that would be great if the label was something like this: BENDnb-RADIUS-DIRECTION-ANGLE-Kfactor, ie. N1-R2-UP-90°-K=0.35

OS: Debian GNU/Linux 10 (buster) (LXDE/LXDE-pi)
Word size of FreeCAD: 64-bit
Version: 0.20.26326 (Git)
Build type: Unknown
Branch: master
Hash: 2cc570757144422a189b9881e650c3878ec58b13
Python version: 3.7.3
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)
janifr
Posts: 9
Joined: Sat Oct 30, 2021 2:05 pm

Re: Sheet Metal Workbench

Post by janifr »

-alex- wrote: Tue Nov 09, 2021 8:08 pm
sorry but I see no effect, Unfold_Sketch_bends is still empty.

You added angle value in code, thanks for that, but angle value is still missing in bendtable. BTW K-factor in bendtable still seems wrong to me.
Other users can give it a try, any comments are welcome.

Thats odd, works here. I suspect there went something wrong with github download. Could you send me your SheetMetalUnfolder.py? I attached a file, if you could try it. If it still doesn't work I'm confused.
-alex- wrote: Tue Nov 09, 2021 8:08 pm OS: Debian GNU/Linux 10 (buster) (LXDE/LXDE-pi)
Word size of FreeCAD: 64-bit
Version: 0.20.26326 (Git)
Build type: Unknown
Branch: master
Hash: 2cc570757144422a189b9881e650c3878ec58b13
Python version: 3.7.3
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)
I have different version, could that be the culprit?
OS: Windows 10 Version 2009
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24291 (Git)
Build type: Release
Branch: releases/FreeCAD-0-19
Hash: 7b5e18a0759de778b74d3a5c17eba9cb815035ac
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.0
Locale: Finnish/Finland (fi_FI)
Attachments
test_sheet_metal_bendtable_unfolder.FCStd
(24.94 KiB) Downloaded 55 times
SheetMetalUnfolder.py
(137.17 KiB) Downloaded 59 times
User avatar
-alex-
Veteran
Posts: 1856
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: Sheet Metal Workbench

Post by -alex- »

janifr wrote: Wed Nov 10, 2021 4:24 am I suspect there went something wrong with github download.
Yes I suspected that as well because I'm not familiar with git stuffs. BTW I didn't git clone your repo, I used the raw copy button on github then I pasted the to replace the previous content of my sheetmetalunfolder.py file.
I assume it had to work but... maybe my bad :?

Anyway, I used your file here linked and it works like a charme on Win system :D
I'll try again on Linux system later.
There is an issue though: "new" bend notes and bendlines objects are not oriented the same way with unfold sketch objects, so that notes don't mach with unfold sketches.
Your job is promising, much appeciated, keep forward :)
janifr
Posts: 9
Joined: Sat Oct 30, 2021 2:05 pm

Re: Sheet Metal Workbench

Post by janifr »

-alex- wrote: Wed Nov 10, 2021 8:26 am There is an issue though: "new" bend notes and bendlines objects are not oriented the same way with unfold sketch objects, so that notes don't mach with unfold sketches.
This is true, new bend lines seem as mirrored lines from sketch. This is something that should be corrected, but need to think a smart way to do it. Best thing would be if there was a way to incorporate bend line indexes to the original sketch. Another option could be automatic generation of cross section views. Both options render obsolete extra object we currently create.
-alex- wrote: Wed Nov 10, 2021 8:26 am Your job is promising, much appeciated, keep forward :)
Thank you for your kind words. I'll try to do my best.
User avatar
-alex-
Veteran
Posts: 1856
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: Sheet Metal Workbench

Post by -alex- »

janifr wrote: Wed Nov 10, 2021 4:40 pm Best thing would be if there was a way to incorporate bend line indexes to the original sketch.
+1
jaisejames
Posts: 384
Joined: Sat Sep 24, 2016 6:51 am

Re: Sheet Metal Workbench

Post by jaisejames »

sfgrayson wrote: Thu Nov 04, 2021 3:03 am Hi,

Is there a way to make the Extend feature still work when not passing through a wall? It works perfectly fine as long as it is going through, but when the respective line is deleted in the base sketch, the extend feature breaks.

This would be very useful for making custom shaped flanges/tabs in general without making a bunch of additional PartDesign features on the Extend.

Great job on the workbench devs, I'm having a blast learning it. I use CAD everyday at work to design chimney parts so I'm very excited to bring FreeCAD into that work and for other sheetmetal workers.

Bug fix push to git.
https://github.com/shaise/FreeCAD_SheetMetal/pull/215

pls test it, if it is working properly.
User avatar
sfgrayson
Posts: 6
Joined: Sun Aug 22, 2021 4:57 pm
Contact:

Re: Sheet Metal Workbench

Post by sfgrayson »

jaisejames wrote: Thu Nov 11, 2021 6:33 am
Bug fix push to git.
https://github.com/shaise/FreeCAD_SheetMetal/pull/215

pls test it, if it is working properly.
Screenshot from 2021-11-11 21-58-18.png
Screenshot from 2021-11-11 21-58-18.png (58.69 KiB) Viewed 2769 times
I will definitely use it more and see but initial testing shows it works very well. This is a gamechanger for certain workflows with lots of flanges/flanges with specific cutouts. For example, in the chimney business we laser-cut rivet holes to make caps and shrouds :D

Thank you!
Attachments
ExtendTest.FCStd
(37.25 KiB) Downloaded 66 times
User avatar
FBXL5
Posts: 980
Joined: Sat Aug 03, 2019 8:45 pm

Re: Sheet Metal Workbench

Post by FBXL5 »

jaisejames wrote: Thu Nov 11, 2021 6:33 am pls test it, if it is working properly.
I tried it and it seems to work properly.

A profile with extension sketch:
ext-10.png
ext-10.png (45.26 KiB) Viewed 2560 times

Result plus another extension sketch (btw - sketch is attached to the original profile):
ext-12.png
ext-12.png (42.61 KiB) Viewed 2560 times
The extended extension works well (subtraction enabled):
ext-13.png
ext-13.png (43.36 KiB) Viewed 2560 times
But one thing puzzles me: How can I build this from sheet metal? ;) :D
ext-14.png
ext-14.png (36.66 KiB) Viewed 2560 times
User avatar
papyblaise
Veteran
Posts: 7875
Joined: Thu Jun 13, 2019 4:28 pm
Location: France

Re: Sheet Metal Workbench

Post by papyblaise »

cut the small bridge , bend , reflat , and weld ;)
Attachments
how to do.PNG
how to do.PNG (27.13 KiB) Viewed 2540 times
Post Reply