Bug: Wrong unit

[openBrain]

PR above merged by @wmayer.
No I released https://github.com/FreeCAD/FreeCAD/pull/5232 that fixes the OP problem.

[wmayer]

While testing the recent locale specific PRs I found a small regression caused by PR 5232.

To test create a QuantitySpinBox with no unit:

Code: Select all

ui=Gui.UiLoader()
w=ui.createWidget("Gui::QuantitySpinBox")
w.show()

When you scroll up/down or use the up/down arrow buttons the value doesn't change. It is stuck at 0.000 (or -0.000).
When setting a unit

Code: Select all

w.setProperty("unit", "m")

it starts to work. But when removing the unit again

Code: Select all

w.setProperty("unit", "")

it is stuck again.

When only reverting the changes made to QuantitySpinBox::stepBy() and leave the rest it works normally again.

git commit b330a83273

[openBrain]

When only reverting the changes made to QuantitySpinBox::stepBy() and leave the rest it works normally again.

git commit b330a83273

Doing so you introduce a regression.
Take any QuantitySpinbox with Unit preference being "Standard".
* Manually enter value of "9999 mm"
* Step up value -> "10 000 mm" -> OK
* Step up value again -> "11 mm" -> Oups

I can have a look at this in coming days if you want. If you have time or prefer to do it by yourself, please let me know.

[wmayer]

Doing so you introduce a regression.

Confirmed.

I can have a look at this in coming days if you want. If you have time or prefer to do it by yourself, please let me know.

Go ahead, please. I will be busy to look at some of the other bugs.

[openBrain]

Go ahead, please. I will be busy to look at some of the other bugs.

PR is here : https://github.com/FreeCAD/FreeCAD/pull/6690