Start Page Redesign

A forum for research and development of the user interface of FreeCAD

Moderator: agryson

User avatar
Kunda1
Posts: 5505
Joined: Thu Jan 05, 2017 9:03 pm

Re: Start Page Redesign

Postby Kunda1 » Tue Jan 15, 2019 2:19 pm

yorik wrote:
Tue Jan 15, 2019 1:47 pm
Several external workbenches have non-standard workbench name probably.
Will the startbench list all the names of the addons installed somewhere in the UI ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
Syres
Posts: 349
Joined: Thu Aug 09, 2018 11:14 am

Re: Start Page Redesign

Postby Syres » Tue Jan 15, 2019 2:43 pm

yorik wrote:
Tue Jan 15, 2019 1:47 pm
Several external workbenches have non-standard workbench name probably.
If someone fancies installing all the addons, then paste here the results of:

Code: Select all

FreeCADGui.listWorkbenches()
That would be a huge help!
@Yorik, this is the output for all installed Workbenches except InventorLoader and kicadStepUpMod due to missing DLLs or dependancies, hope this gets you started:

Code: Select all

{'NoneWorkbench': <__main__.NoneWorkbench object at 0x00000000032C0278>, 'ArchWorkbench': <__main__.ArchWorkbench object at 0x00000000032E8128>, 'CompleteWorkbench': <__main__.CompleteWorkbench object at 0x00000000032C06D8>, 'DraftWorkbench': <__main__.DraftWorkbench object at 0x0000000005D51128>, 'DrawingWorkbench': <__main__.DrawingWorkbench object at 0x00000000032C0710>, 'FemWorkbench': <__main__.FemWorkbench object at 0x00000000032E8208>, 'ImageWorkbench': <__main__.ImageWorkbench object at 0x0000000005D51080>, 'InspectionWorkbench': <__main__.InspectionWorkbench object at 0x0000000005D511D0>, 'MeshWorkbench': <__main__.MeshWorkbench object at 0x0000000005D514E0>, 'OpenSCADWorkbench': <__main__.OpenSCADWorkbench object at 0x0000000005D51748>, 'PartWorkbench': <__main__.PartWorkbench object at 0x0000000005D518D0>, 'PartDesignWorkbench': <__main__.PartDesignWorkbench object at 0x0000000005D51A90>, 'PathWorkbench': <__main__.PathWorkbench object at 0x00000000062428D0>, 'PlotWorkbench': <__main__.PlotWorkbench object at 0x0000000005D51F98>, 'PointsWorkbench': <__main__.PointsWorkbench object at 0x0000000005D51E48>, 'RaytracingWorkbench': <__main__.RaytracingWorkbench object at 0x0000000005D51E80>, 'RobotWorkbench': <__main__.RobotWorkbench object at 0x000000000646B7B8>, 'ShipWorkbench': <__main__.ShipWorkbench object at 0x000000000646BA90>, 'SketcherWorkbench': <__main__.SketcherWorkbench object at 0x000000000646B8D0>, 'SpreadsheetWorkbench': <__main__.SpreadsheetWorkbench object at 0x000000000646B5F8>, 'StartWorkbench': <__main__.StartWorkbench object at 0x00000000064849E8>, 'SurfaceWorkbench': <__main__.SurfaceWorkbench object at 0x0000000006484A90>, 'TechDrawWorkbench': <__main__.TechDrawWorkbench object at 0x0000000006484A58>, 'TestWorkbench': <__main__.TestWorkbench object at 0x0000000006484D30>, 'WebWorkbench': <__main__.WebWorkbench object at 0x0000000006484B38>, 'a2pWorkbench': <__main__.a2pWorkbench object at 0x00000000064A43C8>, 'AirPlaneDesignWorkbench': <__main__.AirPlaneDesignWorkbench object at 0x00000000096EAB38>, 'AnimationWorkbench': <__main__.AnimationWorkbench object at 0x0000000008FDF2E8>, 'ArchTextureWorkbench': <__main__.ArchTextureWorkbench object at 0x00000000064A4240>, 'BIMWorkbench': <__main__.BIMWorkbench object at 0x00000000069D9160>, 'CadQueryWorkbench': <__main__.CadQueryWorkbench object at 0x0000000006AAEEB8>, 'CfdOFWorkbench': <__main__.CfdOFWorkbench object at 0x0000000009DBB1D0>, 'CurvesWorkbench': <__main__.CurvesWorkbench object at 0x000000000A1DC518>, 'DefeaturingWB': <__main__.DefeaturingWB object at 0x000000000A3FE4A8>, 'DynamicDataWorkbench': <__main__.DynamicDataWorkbench object at 0x000000000A5C4B00>, 'ExplodedAssembly': <__main__.ExplodedAssembly object at 0x000000000A5C4D30>, 'FastenersWorkbench': <__main__.FastenersWorkbench object at 0x000000000A609240>, 'flamingoToolsWorkbench': <__main__.flamingoToolsWorkbench object at 0x000000000A609710>, 'Lattice2Workbench': <__main__.Lattice2Workbench object at 0x0000000002E16978>, 'LithophaneWorkbench': <__main__.LithophaneWorkbench object at 0x000000000A5C4BE0>, 'ManipulatorWB': <__main__.ManipulatorWB object at 0x000000000A651630>, 'NurbsWorkbench': <__main__.NurbsWorkbench object at 0x000000000A9CA0B8>, 'PartOMagicWorkbench': <__main__.PartOMagicWorkbench object at 0x000000000A65DC88>, 'SMWorkbench': <__main__.SMWorkbench object at 0x000000000A7733C8>, 'Silk': <__main__.Silk object at 0x000000000A773710>, 'gearWorkbench': <freecad.gears.init_gui.gearWorkbench object at 0x000000000A773E80>, 'frame_workbench': <freecad.frametools.init_gui.frame_workbench object at 0x000000000A773F60>}
RogerK
Posts: 27
Joined: Thu Oct 04, 2018 6:25 pm
Location: Elsau

Re: Start Page Redesign

Postby RogerK » Tue Jan 15, 2019 3:59 pm

saso wrote:
Tue Jan 15, 2019 10:46 am
The installed.png for the installed addons still needs to be added...
Your right, I have missed that, because I have never seen this icon on my machine. This is assigned in the StartPage.js. Do you have an Add-on where this is shown? On my machine this is never shown on the Py2/QT4 build, but I haven't very much Addon's installed.
saso wrote:
Tue Jan 15, 2019 10:46 am
So it works on windows, has it been tested on other platforms, is everything working there? I guess the problem is that since we don't exactly know why this was a problem on windows, we can also not be sure if this was a proper solution :|
I suspect the embedded Webbrowser decided to open the file with http protocoll instead of a local file access. I know earlier Firefox Version had the same issue (at least on Windows) when you just entering the Filepath. In those days you had to add a file:// in front of the path, but this was long time ago.
Syres
Posts: 349
Joined: Thu Aug 09, 2018 11:14 am

Re: Start Page Redesign

Postby Syres » Tue Jan 15, 2019 4:30 pm

Using OS: Windows 7
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15611 (Git)
Build type: Release
Branch: master
Hash: 64a94ae0f7c60fc981086fe157150a9c0dca29c6
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: English/UnitedKingdom (en_GB)

the Addons section displays as:
AvailableAddOns.jpg
AvailableAddOns.jpg (93.67 KiB) Viewed 608 times
User avatar
Kunda1
Posts: 5505
Joined: Thu Jan 05, 2017 9:03 pm

Re: Start Page Redesign

Postby Kunda1 » Tue Jan 15, 2019 7:48 pm

I know this is 'fluff' but it would be cool if the icons of said addons would display next to their names. Brand recognition.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
looo
Posts: 2821
Joined: Mon Nov 11, 2013 5:29 pm

Re: Start Page Redesign

Postby looo » Tue Jan 15, 2019 9:00 pm

Thanks for having a look at this issue @RogerK.
saso wrote:
Tue Jan 15, 2019 10:46 am
So it works on windows, has it been tested on other platforms, is everything working there? I guess the problem is that since we don't exactly know why this was a problem on windows, we can also not be sure if this was a proper solution
I tested a recent build. Startpage now looks the same for linux and windows. I didn't notice any differences for linux. Tested with 0.18.15640.
User avatar
yorik
Site Admin
Posts: 11514
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Start Page Redesign

Postby yorik » Tue Jan 15, 2019 10:02 pm

Thanks for the list, @Kunda1. Those from that list should be fixed with git commit 71d57b376
User avatar
Kunda1
Posts: 5505
Joined: Thu Jan 05, 2017 9:03 pm

Re: Start Page Redesign

Postby Kunda1 » Wed Jan 16, 2019 1:09 am

yorik wrote:
Tue Jan 15, 2019 10:02 pm
Thanks for the list, @Kunda1. Those from that list should be fixed with git commit 71d57b376
That was @Syres not me :D
and thanks @Syres from me too ;)
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
yorik
Site Admin
Posts: 11514
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Start Page Redesign

Postby yorik » Wed Jan 16, 2019 1:34 pm

Kunda1 wrote:
Wed Jan 16, 2019 1:09 am
That was @Syres not me :D
Have been reading too fast once again :D Thanks @Syres
RogerK
Posts: 27
Joined: Thu Oct 04, 2018 6:25 pm
Location: Elsau

Re: Start Page Redesign

Postby RogerK » Thu Jan 17, 2019 6:38 pm

Syres wrote:
Tue Jan 15, 2019 4:30 pm
Thanks for the List. I have now fixed the missing installed icon. In addition there was also another relative filepath (line 419), but the code was just executed when no Workbench icon was found, so normally this would not happen.
StartPage_modfication_file_uri 190117.zip
(8.52 KiB) Downloaded 16 times
The code change was successfuly tested with the Build 15646, with both Py2QT4 and the Py3QT5 x64 Windows Builds.

yorik wrote: ping
I have noticed that in the StartPage.py in line 401 an extra "data" folder is added to the Workbench picture path (FreeCAD.getResourceDir() already points to the data folder). At least on Windows this extra data folder doesn't exist wether in the Py2QT4 nor the Py3QT5 Build. I have removed this extra Folder in the attached StartPage.py too. I hope this is not needed on other Systems.

Code: Select all

img = os.path.join(FreeCAD.getResourceDir(),"data","Mod",wn,"Resources","icons",wn+"Workbench.svg")
looo wrote:
Tue Jan 15, 2019 9:00 pm
Thanks for having a look at this issue @RogerK.
You are welcome, pleased to help out on this. And thank you for testing.