Works great. Everything behaves as advertised.agryson wrote:OK, my test-build works fine. Could all interested and able parties please pull and test?
Toolbar icon size 24px?
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Toolbar icon size 24px?
"fight the good fight"
Re: Toolbar icon size 24px?
Perfect, thank you for testing! I'll have a pull request submitted by this evening.sgrogan wrote:Works great. Everything behaves as advertised.agryson wrote:OK, my test-build works fine. Could all interested and able parties please pull and test?
Re: Toolbar icon size 24px?
Just for clarification: what are talking about is not the property editor but the parameter editor, the thing that looks like the Windows registry.Now if a change is made in the property editor and then a change is made in edit prefs the value reverts to 16 px, first in the list?
This is determined by Qt and depends on system settings. First it tries to get this number from the platform theme and if none is set then it multiplies 24.0 with the factor (dpi/96.0). The dpi is determined by the current screen resolution.I am curious though what causes the default to be 30px on some systems.
If someone has Qt debug libs he could try to track what happens internally:
Code: Select all
from PySide import QtGui
s=QtGui.qApp.style()
s.metaObject().className()
s.pixelMetric(s.PM_ToolBarIconSize)
s.pixelMetric(s.PM_SmallIconSize)
s.pixelMetric(s.PM_LargeIconSize)
Re: Toolbar icon size 24px?
That's what I thought but we had similar systems with similar screens giving varying results.wmayer wrote:This is determined by Qt and depends on system settings. First it tries to get this number from the platform theme and if none is set then it multiplies 24.0 with the factor (dpi/96.0). The dpi is determined by the current screen resolution.
I'll try to do what you suggest to track down the root issue, I'd like to support HDPI screens better.