Ok. I'll try. Ill let you know if I change my mind.bernd wrote: ↑Thu Sep 20, 2018 7:33 pmwow I did not know we have got such a great documantation Will you give it a try bitacovir? If you encounter any problems feel free to ask just here in this topic. You will be a FreeCAD developer after the merge If not just drop a line, I will include it in my next PR.
bernd
make an svg icon from png for a FEM tool
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: make an svg icon from png for a FEM tool
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)
Canal Youtube Grupo Telegram de FreeCAD Español
My personal web site
My GitHub repository
Mini Airflow Tunnel Project
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)
Canal Youtube Grupo Telegram de FreeCAD Español
My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Re: make an svg icon from png for a FEM tool
right on @bitacovirbitacovir wrote: ↑Thu Sep 20, 2018 11:09 pmOk. I'll try. Ill let you know if I change my mind.bernd wrote: ↑Thu Sep 20, 2018 7:33 pmwow I did not know we have got such a great documantation Will you give it a try bitacovir? If you encounter any problems feel free to ask just here in this topic. You will be a FreeCAD developer after the merge If not just drop a line, I will include it in my next PR.
bernd
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: make an svg icon from png for a FEM tool
yeah bitacovir2FreeCADdeveloperKunda1 wrote: ↑Fri Sep 21, 2018 12:23 amright on @bitacovirbitacovir wrote: ↑Thu Sep 20, 2018 11:09 pmOk. I'll try. Ill let you know if I change my mind.bernd wrote: ↑Thu Sep 20, 2018 7:33 pmwow I did not know we have got such a great documantation Will you give it a try bitacovir? If you encounter any problems feel free to ask just here in this topic. You will be a FreeCAD developer after the merge If not just drop a line, I will include it in my next PR.
bernd
Re: make an svg icon from png for a FEM tool
Well. I opened a Github account and installed the Gitkraken software for windows. Also, I followed the instructions from https://www.freecadweb.org/wiki/Develop ... _GitKraken
Now, I have cloned the official repo and have set up my upstream remote repo.
Now. What are the steps to make the Pull Request?
I see pull request buttons on github platform, in the Gitkraken interface and there is this FreeCAD forum Pull Requests.
what protocol should I follow to do the pull request for this graphic icon?
PD: in https://www.freecadweb.org/wiki/Develop ... _GitKraken Point 7) the upstream address is wrong.
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)
Canal Youtube Grupo Telegram de FreeCAD Español
My personal web site
My GitHub repository
Mini Airflow Tunnel Project
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)
Canal Youtube Grupo Telegram de FreeCAD Español
My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Re: make an svg icon from png for a FEM tool
Fixed the wiki page. Thanks @bitacovirbitacovir wrote: ↑Tue Sep 25, 2018 3:44 amWell. I opened a Github account and installed the Gitkraken software for windows. Also, I followed the instructions from https://www.freecadweb.org/wiki/Develop ... _GitKraken
Now, I have cloned the official repo and have set up my upstream remote repo.
Now. What are the steps to make the Pull Request?
I see pull request buttons on github platform, in the Gitkraken interface and there is this FreeCAD forum Pull Requests.
what protocol should I follow to do the pull request for this graphic icon?
PD: in https://www.freecadweb.org/wiki/Develop ... _GitKraken Point 7) the upstream address is wrong.
I made a quick and dirty reference on how to make PRs through Gitkraken at
Developing_FreeCAD_with_GitKraken#Making_Pull_Requests
I will refine it later. Hope that helps.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: make an svg icon from png for a FEM tool
Thanks @Kunda1Kunda1 wrote: ↑Tue Sep 25, 2018 10:09 am I made a quick and dirty reference on how to make PRs through Gitkraken at
Developing_FreeCAD_with_GitKraken#Making_Pull_Requests
I will refine it later. Hope that helps.
Now. I have a question. Should I make a new branch for a pull request? Even if I'm not doing any code?
I mean, bernd asked me to make the PR with a reference to this forum topic, where the svg file is. I understand I must write an explanation and the link to here in the description of the PR's dialog box. Should this description be enough? No problem with an empty branch?
I just don't want to do something that the developer community could find annoying.
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)
Canal Youtube Grupo Telegram de FreeCAD Español
My personal web site
My GitHub repository
Mini Airflow Tunnel Project
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)
Canal Youtube Grupo Telegram de FreeCAD Español
My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Re: make an svg icon from png for a FEM tool
The simple answer is, Yes. This is the convention used when someone wants to contribute to a git version control system project that you will encounter. Only those that have permission to merge code in to the master branch directly. Everyone else submits their contributions in a separate branch (that is branched off of the 'master' branch, or whatever the project deem as 'master').bitacovir wrote: ↑Thu Sep 27, 2018 2:05 pmThanks @Kunda1Kunda1 wrote: ↑Tue Sep 25, 2018 10:09 am I made a quick and dirty reference on how to make PRs through Gitkraken at
Developing_FreeCAD_with_GitKraken#Making_Pull_Requests
I will refine it later. Hope that helps.
Now. I have a question. Should I make a new branch for a pull request? Even if I'm not doing any code?
So you make a branch, checkout that branch, make the changes to the source (modify the code, add files, remove files...whatever) and then you submit the PR. As for the summary, You can make a reference to this forum thread (if you can link directly to the most informative portion of the thread is a nice consideration for the core devs time) and maybe share some summarizing words what the necessity of the PR is.bitacovir wrote: ↑Thu Sep 27, 2018 2:05 pm I mean, bernd asked me to make the PR with a reference to this forum topic, where the svg file is. I understand I must write an explanation and the link to here in the description of the PR's dialog box. Should this description be enough? No problem with an empty branch?
I know the feeling. I've stepped on some folks toes here and ignorantly overlooked contribution norms. In general what is nice in this community is that folks are reasonable and cool. So if you make a mistake, you'll most likely be told and then shown how to remedy it. This is how we learn. I think it's great you're contributing which is the spirit of FOSS.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: make an svg icon from png for a FEM tool
- make a new branch
- make a commit wich adds the new icon
- make a PR with this branch
sure you gone make no code, but a new icon is some development since icons are part of the code ... BTW only if you make a commit in a separate branch and make a PR with this you will be a developer.
As an example see:
PR:
https://github.com/FreeCAD/FreeCAD/pull/1691
the branch on the developers github
https://github.com/furti/FreeCAD/commit ... r-all-icon
the commit in FreeCAD after the merge:
git commit f054788
- make a commit wich adds the new icon
- make a PR with this branch
sure you gone make no code, but a new icon is some development since icons are part of the code ... BTW only if you make a commit in a separate branch and make a PR with this you will be a developer.
As an example see:
PR:
https://github.com/FreeCAD/FreeCAD/pull/1691
the branch on the developers github
https://github.com/furti/FreeCAD/commit ... r-all-icon
the commit in FreeCAD after the merge:
git commit f054788
Re: make an svg icon from png for a FEM tool
It's not working. When I click on Create Pull Request button, it shows a message saying "Fail to create a Pool Request. No commits between FreeCAD:master and bitacovir:new-fem-svgicon-branch"bernd wrote: ↑Thu Sep 27, 2018 4:54 pm - make a new branch
- make a commit wich adds the new icon
- make a PR with this branch
sure you gone make no code, but a new icon is some development since icons are part of the code ... BTW only if you make a commit in a separate branch and make a PR with this you will be a developer.
As an example see:
PR:
https://github.com/FreeCAD/FreeCAD/pull/1691
the branch on the developers github
https://github.com/furti/FreeCAD/commit ... r-all-icon
the commit in FreeCAD after the merge:
git commit f054788
But I made the commit in my new-fem-svgicon-branch (see screenshot)
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)
Canal Youtube Grupo Telegram de FreeCAD Español
My personal web site
My GitHub repository
Mini Airflow Tunnel Project
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)
Canal Youtube Grupo Telegram de FreeCAD Español
My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Re: make an svg icon from png for a FEM tool
bitacovir wrote: ↑Sat Sep 29, 2018 2:58 am It's not working. When I click on Create Pull Request button, it shows a message saying "Fail to create a Pool Request. No commits between FreeCAD:master and bitacovir:new-fem-svgicon-branch"
But I made the commit in my new-fem-svgicon-branch (see screenshot)
gitkraken_2018-09-28_23-58-51.png
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs