[SOLVED] Request for 2 new icons: Draft join and split

A forum for research and development of the user interface of FreeCAD

Moderator: agryson

User avatar
Moult
Posts: 196
Joined: Sat Jan 05, 2019 11:46 am
Contact:

[SOLVED] Request for 2 new icons: Draft join and split

Postby Moult » Tue Jan 29, 2019 12:31 pm

Good morning all! I am building two new features for the Draft workbench: the join and split tool. The join tool is where you can take two wires and if they are joined at one end, it will join them into a single wire. This is a typical tool in most CAD software. The split does the opposite - you can take a wire and split it into two wires at a point.

This is the PR: https://github.com/FreeCAD/FreeCAD/pull/1936

Is there an artist who can please help make two icons for these two functions?
Last edited by Moult on Wed Jan 30, 2019 9:28 am, edited 1 time in total.
I also blog about 3D rendering, architecture, software and other on thinkMoult.com. RSS / Atom feed available for your convenience.
User avatar
bitacovir
Posts: 600
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: Request for 2 new icons: Draft join and split

Postby bitacovir » Tue Jan 29, 2019 1:42 pm

Hi, I will happy to help you.
Do you have a symbol in mind?
I know that join in CAD is something like this: https://www.iconfinder.com/icons/124350 ... _join_icon
And split is something like this: https://www.iconfinder.com/icons/778153 ... split_icon
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My Blog
Mini Airflow Tunnel Project
chrisb
Posts: 15827
Joined: Tue Mar 17, 2015 9:14 am

Re: Request for 2 new icons: Draft join and split

Postby chrisb » Tue Jan 29, 2019 1:55 pm

Moult wrote:
Tue Jan 29, 2019 12:31 pm
Good morning all! I am building two new features for the Draft workbench: the join and split tool. The join tool is where you can take two wires and if they are joined at one end, it will join them into a single wire.
Where is the difference to Draft->Upgrade?
User avatar
bitacovir
Posts: 600
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: Request for 2 new icons: Draft join and split

Postby bitacovir » Tue Jan 29, 2019 2:26 pm

What about a quick combination of FreeCAD Icon elements:
Draft Join Tool
inkscape_2019-01-29_11-21-58.png
inkscape_2019-01-29_11-21-58.png (12.03 KiB) Viewed 347 times
Draft Split Tool
inkscape_2019-01-29_11-23-11.png
inkscape_2019-01-29_11-23-11.png (11.77 KiB) Viewed 347 times
Draft_Join.svg
(17.94 KiB) Downloaded 43 times
Draft_Split.svg
(16.91 KiB) Downloaded 41 times
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My Blog
Mini Airflow Tunnel Project
User avatar
Moult
Posts: 196
Joined: Sat Jan 05, 2019 11:46 am
Contact:

Re: Request for 2 new icons: Draft join and split

Postby Moult » Tue Jan 29, 2019 8:39 pm

Hey thanks! The Icons look great!

The upgrade and downgrade tool actually converts the object to another type. It is certainly possible to join and split a line by a series of combination of upgrades, downgrades, and convert to sketch, but it is a multiple step process. In architectural drafting, this join and splitting function is done hundreds of times a day, and so it is useful to have it in one tool.

This is the thread that started it:

https://forum.freecadweb.org/viewtopic. ... 9&start=20
I also blog about 3D rendering, architecture, software and other on thinkMoult.com. RSS / Atom feed available for your convenience.
triplus
Posts: 8364
Joined: Mon Dec 12, 2011 4:45 pm

Re: Request for 2 new icons: Draft join and split

Postby triplus » Tue Jan 29, 2019 10:08 pm

Nice to see Draft workbench getting some new features.

@bitacovir

Thanks for the artwork.
carlopav
Posts: 144
Joined: Mon Dec 31, 2018 1:49 pm

Re: Request for 2 new icons: Draft join and split

Postby carlopav » Wed Jan 30, 2019 8:08 am

Moult wrote:
Tue Jan 29, 2019 12:31 pm
The join tool is where you can take two wires and if they are joined at one end, it will join them into a single wire.
Great!
What about if the tool could work also on lines that are not joined at one end, and extend automatically both to the intersection point?
User avatar
Moult
Posts: 196
Joined: Sat Jan 05, 2019 11:46 am
Contact:

Re: Request for 2 new icons: Draft join and split

Postby Moult » Wed Jan 30, 2019 8:27 am

I believe what you are describing is a trim / extend / chamfer tool, at least in AutoCAD / Revit lingo that's what it is :) I will play around with the trim tool and see if it is sufficient.

The icons have now been committed to the PR. Thanks very much!
I also blog about 3D rendering, architecture, software and other on thinkMoult.com. RSS / Atom feed available for your convenience.
User avatar
bitacovir
Posts: 600
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: [SOLVED] Request for 2 new icons: Draft join and split

Postby bitacovir » Wed Jan 30, 2019 10:32 am

You are welcome.
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My Blog
Mini Airflow Tunnel Project
User avatar
yorik
Site Admin
Posts: 11163
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: [SOLVED] Request for 2 new icons: Draft join and split

Postby yorik » Wed Jan 30, 2019 12:54 pm

Nice icons!!

The trim/extend tool should also gain some love.. Many people find it tricky to use, basically because (I think) although it has the same name as autocad, it doesn't behave like autocad (select boundaries first). But I find it more interesting how it is now...

Also, that tool is also able to extrude if you select a face. That has actually nothing to do with trimming, maybe it should be separated into a different tool...