we could use a short version for labels:
TOP
BTM
FRNT
REAR
LFT
RX
SX
Still there is a need to add an uniform letter-spacing.
Moderator: agryson
Code: Select all
sansFont.setStretch(QFont::ExtraCondensed);
@wmayer: Thanks for your finding. Interesting... maybe its some kind of bug in Qt for Windows? Does the bottom layer label still fit within the face boundaries when it's commented out?wmayer wrote: ↑Mon Apr 15, 2019 9:01 amThe culprit of the bad look is this line:When commenting it out the text looks much better.Code: Select all
sansFont.setStretch(QFont::ExtraCondensed);
Possible. At least with Qt4.8 it looks good and there is no change required. With Qt5.6 or Qt5.12 the change is required.Thanks for your finding. Interesting... maybe its some kind of bug in Qt for Windows?
It's clearly outside of the cube's face. The letters "B" and "m" lie on the rounded edges of the cube.Does the bottom layer label still fit within the face boundaries when it's commented out?
I once had the situation that text painted on a GL canvas was truncated and after upgrading the graphic driver the issue was gone. So, it's possible that on your system it might look good but then on another computer it doesn't.With this offending line I could squeeze in a larger font on a face while making the cube smaller and still keep the same readability level. But with this being broken on Windows we shouldn't merge this PR for sure! Thanks again for verifying this.
I might try the Windows build next time before making a pull request, but I don't have the toolchain set up on Windows yet. I won't be able to verify the macOS build though - not a mac owner.
Thanks. I'll see once I have all the build tools and libs set up on Windows. In the mean time I did a quick fix here: https://github.com/tyszja/FreeCAD/tree/naviCube_improve It removes the Condensed parameter and applies an upper size limit to a label only when it's to large to fit... this should now only affect the bottom face. As a result the bottom face should now use a slightly smaller font size than all the other use - it slightly breaks the consistency on this single face but shouldn't hurt your eyes too much.wmayer wrote: ↑Mon Apr 22, 2019 10:56 amPossible. At least with Qt4.8 it looks good and there is no change required. With Qt5.6 or Qt5.12 the change is required.Thanks for your finding. Interesting... maybe its some kind of bug in Qt for Windows?It's clearly outside of the cube's face. The letters "B" and "m" lie on the rounded edges of the cube.Does the bottom layer label still fit within the face boundaries when it's commented out?
I guess this has something to do that in Qt5.x the whole OpenGL support has been reworked. I remember that in the old QGLWidget class there was a method to paint text and with the workarounds for Qt5 the text looks really ugly.
For the Image module I once found a nice solution based on QPainterPath and the rendered text looks nice. See GLImageBox::renderText. Maybe the same idea (at least for Qt5 on Windows) could be applied on the NaviCube.
I once had the situation that text painted on a GL canvas was truncated and after upgrading the graphic driver the issue was gone. So, it's possible that on your system it might look good but then on another computer it doesn't.With this offending line I could squeeze in a larger font on a face while making the cube smaller and still keep the same readability level. But with this being broken on Windows we shouldn't merge this PR for sure! Thanks again for verifying this.
I might try the Windows build next time before making a pull request, but I don't have the toolchain set up on Windows yet. I won't be able to verify the macOS build though - not a mac owner.
Please put all NaviCube settings into its own tab. The current 3D view page is already a bit overloaded and there shouldn't be added more widgets. Keep in mind that there are users with relative small displays and when a page has too many controls then it affects usability (if things work correctly then a scrollbar is shown, if not then the page is truncated).New and old look comparison attached. Left is the new one
Right... When I looked at the current state of the 3D View tab with all these widgets mixed up with no sense I thought that no one thinks about the usability. Good I was wrong. I got your point, thanks.
seven labels for six faces?
Code: Select all
# North
#
# +-----------+
# / /|
# / Top / |
# / / |
# / / |
# +-----------+ |
# | | +
# | | / East
# West | South | /
# | | /
# | |/
# +-----------+
# z
# ^ Bottom
# | y
# | /
# |/
# +------> x