FreeCAD 0.19 UI issue: Dropdown menu options without logo are misaligned (due to stylesheet issue)

[Kunda1]

In the screencast you can see that the options in the dropdowns that are missing logos are shifted over to the left instead of being indented.



This is visually disruptive and is lacking symmetry.
I propose that it be corrected.

Edit:
Notice the Accessories dropdown is indented correctly

Edit2:
OS: Manjaro Linux (XFCE/xfce)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18213 (Git) AppImage
Build type: Release
Branch: master
Hash: 22babc09954ac6fda9135ee71d68550921659b1c
Python version: 3.7.3
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)

[vocx]

In the screencast you can see that the options in the dropdowns that are missing logos are shifted over to the left instead of being indented.

You didn't specify your information. I, therefore, conclude that Manjaro sucks.

It works fine in Ubuntu.

Menu_aligned.png (37.16 KiB) Viewed 1830 times

Code: Select all

OS: Ubuntu 18.04.3 LTS (ubuntu:GNOME/ubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18240 +1 (Git)
Build type: Unknown
Branch: Arch_subtract_color
Hash: b51cfd65d9353689b971d8543542d563a5268642
Python version: 3.6.8
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)

[Kunda1]

[vocx]

I'd also disable or test other stylesheets. I don't know if they control at all how the software aligns things in the menus. It could be the operating system stylesheet, the FreeCAD stylesheet, or even the version of Qt.

[bitacovir]

All is fine in my windows 10.

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18213 (Git)
Build type: Release
Branch: master
Hash: 22babc09954ac6fda9135ee71d68550921659b1c
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)

[Kunda1]

I'd also disable or test other stylesheets. I don't know if they control at all how the software aligns things in the menus. It could be the operating system stylesheet, the FreeCAD stylesheet, or even the version of Qt.

You are correct sir, it was the stylesheet. All icons aligned normally after disabling stylesheet.
I can confirm the issue exists in all the dark, darker, and light stylesheets

Edit: can anyone else confirm ?

[pablogil]

I’ll have a look at it.
I haven’t tested the menus intensively as I’m developing the stylesheets under macOS.

Thanks for the ping

[pablogil]

After seeing this issue, I think the best solution is that all menus entries have an icon, or as default, a "blank" icon.
This way the blank icon would be loaded and all entries would be aligned.

Any programmer could take care of this? I can just create the blank SVG icon...

Cheers

[wmayer]

Confirmed with:
OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18723 (Git)
Build type: Release
Branch: master
Hash: d61bf15c42d1a88e0e09de2e3894e195c37c69cd
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)


Another issue is that menu text of enabled and disabled commands looks the same so it's almost impossible to distinguish between them. The only visual help is if a command has an icon because this appears greyed out.

[wmayer]

https://bugreports.qt.io/browse/QTBUG-78123
https://bugreports.qt.io/browse/QTBUG-78238

The bug QTBUG-78123 seems to be fixed but I couldn't see the relevant code changes.