Here all cursors always have the symbol bottom right of crosshair. Which seems sensible.
EDIT:
For the line it's bottom right of the center, for rectangle it's bottom right of the crosshair
Great! Incorporated in https://github.com/FreeCAD/FreeCAD/pull/3712mikeprice99 wrote: ↑Sat Jul 25, 2020 10:51 am If you do want the cursors recreated in svg, it's now taking me less than 5 minutes per cursor.
Thanks - its very rewarding for contributors like me to see our efforts quickly adopted.vanuan wrote: ↑Sun Jul 26, 2020 2:19 am Great! Incorporated in https://github.com/FreeCAD/FreeCAD/pull/3712
Could you please interactively rebase your branch and squash/fixup your commits so they are presented in a logical condensed way (eg. you can merge all the commits that handles change to SVG icons) ?vanuan wrote: ↑Sun Jul 26, 2020 2:19 am Great! Incorporated in https://github.com/FreeCAD/FreeCAD/pull/3712
I can squash all the commits if it would be easier to review. It is ready to review and merge, nothing is broken.openBrain wrote: ↑Sun Jul 26, 2020 8:12 amCould you please interactively rebase your branch and squash/fixup your commits so they are presented in a logical condensed way (eg. you can merge all the commits that handles change to SVG icons) ?vanuan wrote: ↑Sun Jul 26, 2020 2:19 am Great! Incorporated in https://github.com/FreeCAD/FreeCAD/pull/3712
Could you also indicate your PR isn't ready to merge yet so maintainers doesn't consume time looking at it ?
I didn't have a close look. Maybe git commit fdfda05 and git commit a3af118 that add implementation can be kept separated.
It's definitely not ready. Not all symbols are ported to SVG, this is totally partial. While 0.19 is coming closer to release every day, this is really not sensible to merge such an unfinished PR.It is ready to review and merge, nothing is broken.