As long as you're happy with what I've given, then I'm happy. Let's not add any complications.
Hi guys, I have not looked at the code etc. however two thoughts, ideally all Mike's SVG files should be in one git commit but regardless he should create a git repo and commit his files to it and then vanuan should pull that so that although it can be one PR to FreeCAD, it will show up in the git history as two commits and hence credit to each person's work.
I think Mike intentionally doesn't want any metadata which isn't used in the production app. Add several kilobytes to each svg and you've got several megabytes of wasted space. Of course, it's zipped and extracted to /tmp but it's still an overhead.
So what do you need now? More SVG files for the rest of the icons? I am not a developer, so just give me a simple task.vanuan wrote: ↑Tue Jul 21, 2020 7:48 pm
First SVG cursor is ready to review!
Now the problem is with constraints icons: https://github.com/FreeCAD/FreeCAD/tree ... cons/small
Screenshot from 2020-07-21 22-34-43.png
Also, need to figure out how to set crosshair color.
Exactly! I presume with svg based cursors the cursors are being created fomr the svg when the workbench is first opened. During this operation, each svg will be opened, parsed and the cursor built. The smaller and more precise the svg file, the quicker it'll work: FreeCAD will appear more responsive. (I also want to optimise all the button icon svgs)
Unfortunately, some of the contents of these SVGs is very complex. On inspection, most of the current SVGs contain multiple gradient definitions that are totally unused. Graphical objects are drawn in one place, then moved, sometimes more than once.
Now, I need somebody to review the code and hopefully merge it. Then a daily build should be released so that users would test and report remaining issues if any.
This is in general not needed. All code in FreeCAD is implicitly either LGPL2, or Creative Commons 3.0 for the artwork.
By the way, don't despair. This is how FreeCAD works. Occasionally it takes weeks and months for pull requests to be merged. So just sit tight and enjoy the ride.
If you want to improve the SVG icons, go ahead; I think they definitely could use some work. For example, they should all be Plain SVG and have a native resolution of 96 dpi.