[FIXED] Ticket #4493 - InsertDatum.ui dialog height too small

A forum for research and development of the user interface of FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: InsertDatum.ui dialog height too small

Post by wmayer »

dennisb wrote: Sun Nov 15, 2020 9:19 am It would be nice if someone on Mac/Windows could test without the <property name="minimumSize"> node in InsertDatum.ui so we can see if it still work in other os:es.
Nice finding! It looks it's a regression caused by git commit 2d9c2c64. I will remove the minimum size hint from the UI file and test how it behaves on Linux and Windows. If it is OK I will commit the changes.

Thank you very much!
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: InsertDatum.ui dialog height too small

Post by wmayer »

User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: InsertDatum.ui dialog height too small

Post by Kunda1 »

Awesome!
OP please mark this thread [FIXED] by editing the first post title summary.
Thanks to all involved!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
dennisb
Posts: 9
Joined: Sat Nov 14, 2020 11:19 am

Re: [FIXED] InsertDatum.ui dialog height too small

Post by dennisb »

Before starting this thread I made the mistake of opening issue #4493 but it doesn't look like I have permission to close it again.

Thanks for the help fixing this. I still don't know why there is a dialog height of 140 set in the ui file. It doesn't hurt and maybe it helps someone on some OS but it can probably also be removed.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: [FIXED] Ticket #4493 - InsertDatum.ui dialog height too small

Post by Kunda1 »

Closed issue #4493
Thank you.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [FIXED] InsertDatum.ui dialog height too small

Post by wmayer »

dennisb wrote: Sun Nov 15, 2020 12:49 pm Thanks for the help fixing this. I still don't know why there is a dialog height of 140 set in the ui file. It doesn't hurt and maybe it helps someone on some OS but it can probably also be removed.
For each UI file a width and height is set. You cannot remove that. Since a dialog must have a layout the defined size doesn't matter because the dialog will expand if necessary.
Dr_Pi
Posts: 1
Joined: Wed Jul 28, 2021 6:34 am

Re: [FIXED] Ticket #4493 - InsertDatum.ui dialog height too small

Post by Dr_Pi »

I still get this issue in 0.19.

OS: Linux Mint 20.1 (X-Cinnamon/cinnamon)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Branch: unknown
Hash: 0d9536ed3e8c7f40197b5606e1b7873625e1d6fe
Python version: 3.8.10
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.5.2
Locale: English/United Kingdom (en_GB)
Attachments
Selection_014.png
Selection_014.png (21.47 KiB) Viewed 2800 times
chrisb
Veteran
Posts: 53920
Joined: Tue Mar 17, 2015 9:14 am

Re: [FIXED] Ticket #4493 - InsertDatum.ui dialog height too small

Post by chrisb »

Dr_Pi wrote: Wed Jul 28, 2021 6:40 am I still get this issue in 0.19.
You can try to reset the configuration with the button in the preferences. Another possibility is to delete your config files or to move them in case you want to restore them.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: [FIXED] Ticket #4493 - InsertDatum.ui dialog height too small

Post by Syres »

Dr_Pi wrote: Wed Jul 28, 2021 6:40 am
Hash: 0d9536ed3e8c7f40197b5606e1b7873625e1d6fe
I don't know where you got that version of 0.19 (it looks like an old PPA) but the correct hash for 0.19.2 is 7b5e18a0759de778b74d3a5c17eba9cb815035ac as shown in the Windows build below. I might not be searching the commits correctly but I can't even find your quoted commit in the FreeCAD master list.

OS: Windows 7 Version 6.1 (Build 7601: SP 1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24291 (Git)
Build type: Release
Branch: releases/FreeCAD-0-19
Hash: 7b5e18a0759de778b74d3a5c17eba9cb815035ac
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/United Kingdom (en_GB)
Post Reply