New ProDark Theme with 4k small text Mod

A forum for research and development of the user interface of FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: New ProDark Theme with 4k small text Mod

Post by Kunda1 »

RatonLaveur wrote: Mon Feb 15, 2021 10:23 am For what it's worth, I am upvoting this!
And I sir.... am upvoting YOUR upvote!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: New ProDark Theme with 4k small text Mod

Post by turn211 »

Kunda1 wrote: Sun Feb 14, 2021 10:32 pm
turn211 wrote: :bell:
Time to make a PR to FreeCAD/src/Gui/Stylesheets/ ?
Will do..If i knew how :lol:
1. Go to https://github.com/FreeCAD/FreeCAD/comp ... eeCAD-0-18
2. Create PR button
3. Delete how to info
4. Write info and attach file
5. Where do i say FreeCAD/src/Gui/Stylesheets/
6. This could all be wrong :oops:
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: New ProDark Theme with 4k small text Mod

Post by Kunda1 »

turn211 wrote: Mon Feb 15, 2021 6:10 pm Will do..If i knew how :lol:
1. Go to https://github.com/FreeCAD/FreeCAD/comp ... eeCAD-0-18
2. Create PR button
3. Delete how to info
4. Write info and attach file
5. Where do i say FreeCAD/src/Gui/Stylesheets/
6. This could all be wrong :oops:
Nice try. You want the PR against master branch not FreeCAD-0-18
This is documented in https://wiki.freecadweb.org/Source_code ... rk_locally

In your browser go to https://github.com/FreeCAD/FreeCAD
Press the fork button
You should have a fork called https://github.com/turn211/FreeCAD

In the command line terminal:

Code: Select all

git clone https://github.com/turn211/FreeCAD
git remote add upstream https://github.com/FreeCAD/FreeCAD
git checkout master
git branch ProDark-Theme
git checkout ProDark-Theme
Copy your files in to src/Gui/Stylesheets/

Code: Select all

git add .
git commit -m "Gui: Add new stylesheet ProDark theme" -m "forum thread: https://forum.freecadweb.org/viewtopic.php?f=34&t=55134"
git push origin ProDark-Theme
You'll get asked for you user/pass in the terminal to push you changes to your fork on github.

Go to https://github.com/turn211/FreeCAD

You'll see a link at the top of the page asking if you want to compare and make a PR. Click it.
The details of the PR should be in there. If not then copypaste them in.
Press Make Pull Request.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: New ProDark Theme with 4k small text Mod

Post by turn211 »

Kunda1 wrote: Mon Feb 15, 2021 7:18 pm
Nice try...
Thanks. Nicest thing anybody has said to me today :) Completed. I forgot to tag the PR [UI] though. Still learning.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: New ProDark Theme with 4k small text Mod

Post by Kunda1 »

turn211 wrote: Mon Feb 15, 2021 11:48 pm
Kunda1 wrote: Mon Feb 15, 2021 7:18 pm
Nice try...
Thanks. Nicest thing anybody has said to me today :) Completed. I forgot to tag the PR [UI] though. Still learning.
The way to do that is with git commit --amend
If you want to learn git in a great way check out this thread: https://forum.freecadweb.org/viewtopic.php?f=8&t=51557
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
RatonLaveur
Posts: 991
Joined: Wed Mar 27, 2019 10:45 am

Re: New ProDark Theme with 4k small text Mod

Post by RatonLaveur »

turn211 wrote: Mon Feb 15, 2021 11:48 pm Thanks. Nicest thing anybody has said to me today :) Completed. I forgot to tag the PR [UI] though. Still learning.
Good hustle!
Keep em coming!
Stay Golden!
and my personal favourite:
...not bad...
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: New ProDark Theme with 4k small text Mod

Post by Kunda1 »

turn211 wrote: Mon Feb 15, 2021 11:48 pm Thanks. Nicest thing anybody has said to me today :) Completed. I forgot to tag the PR [UI] though. Still learning.
You want to close the PR and try again, this time making your own branch off of master?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: New ProDark Theme with 4k small text Mod

Post by turn211 »

I closed the PR. I'm going to delete turn211/FreeCAD repository also and start again. Clean slate Ok?
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: New ProDark Theme with 4k small text Mod

Post by Kunda1 »

turn211 wrote: Tue Feb 16, 2021 7:08 pm I closed the PR. I'm going to delete turn211/FreeCAD repository also and start again. Clean slate Ok?
Not necessary to delete the whole repo.
Are you purely working on Github or are you working on you computer locally and then pushing to github ?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: New ProDark Theme with 4k small text Mod

Post by turn211 »

Home for Lunch. PR completed. Thanks
Post Reply