Need Help on populating user colors with Stylesheet change.

[Kunda1]

Purely technical coding question for the devs reading this

There was/is an ongoing discussion about this regarding Addons. This would qualify as an addon, per se.
https://github.com/FreeCAD/FreeCAD-addo ... -303949382

[chennes]

As far as I can find in FreeCAD, we don't have any code that actually parses the metadata.txt file -- just code that scans it for a few key entries. Am I missing something?

[chennes]

The UI for this is pretty straightforward: here's a first take on it...

Screenshot 2021-04-01 093657.png (78.41 KiB) Viewed 2835 times

ETA: The "Apply" button becomes "Reapply" once a theme has been applied.

[turn211]

The UI for this is pretty straightforward: here's a first take on it...

Screenshot 2021-04-01 093657.png

ETA: The "Apply" button becomes "Reapply" once a theme has been applied.

Looks good! Any reason we still need the Stylesheet picker?

[chennes]

I think so -- certainly at first, not all stylesheets will be wrapped by the Theme. And the action of the theme is to do more than set the stylesheet -- it will be possible to create a theme that doesn't affect the stylesheet at all, but (for example) just sets the colors of the console, or something like that. In this setup, "Theme" is just some arbitrary collection of user preferences.

[turn211]

I think so -- certainly at first, not all stylesheets will be wrapped by the Theme. And the action of the theme is to do more than set the stylesheet -- it will be possible to create a theme that doesn't affect the stylesheet at all, but (for example) just sets the colors of the console, or something like that. In this setup, "Theme" is just some arbitrary collection of user preferences.

True. I'm trying to wrap my mind around which one overrides the other.

[turn211]

I think so -- certainly at first, not all stylesheets will be wrapped by the Theme. And the action of the theme is to do more than set the stylesheet -- it will be possible to create a theme that doesn't affect the stylesheet at all, but (for example) just sets the colors of the console, or something like that. In this setup, "Theme" is just some arbitrary collection of user preferences.

So if a Stylesheet is present in the theme Style Sheet = none ?

[chennes]

Think of a Theme as a macro that sets a bunch of preferences (including the stylesheet). So anything you do after you hit apply on the theme still applies, including setting the stylesheet. We're not getting rid of the various preferences options, just giving theme creators an easy way of setting those options all at once.

(Aside: This is a little bit untrue because we have to have a mechanism for a theme to set value in workbenches that haven't been loaded yet, but it gets at the basic idea anyway.)

[turn211]

Think of a Theme as a macro that sets a bunch of preferences (including the stylesheet). So anything you do after you hit apply on the theme still applies, including setting the stylesheet. We're not getting rid of the various preferences options, just giving theme creators an easy way of setting those options all at once.

(Aside: This is a little bit untrue because we have to have a mechanism for a theme to set value in workbenches that haven't been loaded yet, but it gets at the basic idea anyway.)

Got it. Thanks. Exciting!

[turn211]

The UI for this is pretty straightforward: here's a first take on it...
ETA: The "Apply" button becomes "Reapply" once a theme has been applied.

It would be nice to have a Please restart FreeCAD popup after changing themes or Style Sheet as Qss code in ProDark Theme (might be others) cannot update certain elements without restarting (i.e. url link colors)