Icons of Select File window disappear with Dark themes

[bitacovir]

I just notice that the icons in the "select a file" window don't display under Dark Themes.

freecad_TsC0509Sqv.png (39.26 KiB) Viewed 2558 times

freecad_0oJ4pxq1Fh.png (36.87 KiB) Viewed 2558 times

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24267 (Git)
Build type: Release
Branch: master
Hash: b2ca86d8d72b636011a73394bf9bcdedb3b109b7
Python version: 3.8.8
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)

[turn211]

I just notice that the icons in the "select a file" window don't display under Dark Themes.

I'll check it out. How do I get to "select a file"?

[chennes]

They show for me (I am testing by using Tools->Save picture so I make sure I'm not getting the native dialog):

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.20.24642 +1 (Git)
Build type: Debug
Branch: openscadTrueProjection
Hash: 1b935db4664799e2d240c90078ddb2a1142aea13
Python version: 3.8.6+
Qt version: 5.15.1
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/United States (en_US)

[chennes]

I just notice that the icons in the "select a file" window don't display under Dark Themes.

It looks to me like they are in fact displaying, now that I look closer -- they are just very tiny. Or is that my imagination?

[turn211]

I just notice that the icons in the "select a file" window don't display under Dark Themes.

It looks to me like they are in fact displaying, now that I look closer -- they are just very tiny. Or is that my imagination?

Icons show as avertised (i would say 16px) on my Box testing with Tools->Save picture I looked in the stylesheets and there are no max-height limits. Anyone else?

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.20.24673 (Git)
Build type: Release
Branch: master
Hash: e66ed26769ce8affe0a4ed330ff0435f4802f05e
Python version: 3.8.6+
Qt version: 5.15.1
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/Canada (en_CA)

[chennes]

They appear to be in boxes with the theme applied -- is there a way to make it so they remain just the icons, as they are in the default? I don't know that in this window it makes sense to display the icons inside a button rectangle.

[turn211]

They appear to be in boxes with the theme applied -- is there a way to make it so they remain just the icons, as they are in the default? I don't know that in this window it makes sense to display the icons inside a button rectangle.

I looked. They are hardcoded as QToolButtons inside the Gui--FileOptionsDialog.

[chennes]

I looked. They are hardcoded as QToolButtons inside the Gui--FileOptionsDialog.

So for them to appear different from other QToolButtons when a theme is applied, they need to be subclassed?

[turn211]

I looked. They are hardcoded as QToolButtons inside the Gui--FileOptionsDialog.

So for them to appear different from other QToolButtons when a theme is applied, they need to be subclassed?

They could be called by their Object name and do the following to display the raw icon if it helps. All works fine on my box so hard to Debug.

Code: Select all

	Gui--FileOptionsDialog#QFileDialog QToolButton {
    	padding: 0px;
    	border: 0px;
   	margin: 0px;
}

[bitacovir]

They show for me (I am testing by using Tools->Save picture so I make sure I'm not getting the native dialog):

Sorry, I forgot to mention the actual command.
In DraftWB - Draft ShapeString command - In the panel, option "..." of Font file.
You are right that icons in other windows work fine. In my case too. But in this window icons are shown very tiny in dark themes.