TechDraw Icon name/functionality uniformity

A forum for research and development of the user interface of FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

TechDraw Icon name/functionality uniformity

Post by Kunda1 »

This thread tracks the work of
  • Organizing the TechDraw.qrc file (link)
  • Renaming the TechDraw sPixmap variables which are essentially the SVG icon names of each TechDraw function to mirror the name of the function. Or in certain instances changing the function name to accommodate the icon name because it is more appropriate
  • Making sure the sWhatsThis variable mirrors the icon name which will invoke the correct wiki page when using the Std WhatsThis command in the FreeCAD GUI
  • That each TechDraw icon is named in a uniform standard as other workbenches are: <Workbench>_<Function>
    Example: TechDraw_ClipGroupRemove instead of techdraw-ClipGroupRemove or TechDraw_ClipGroup_Remove
  • Converting all Inkscape formatted SVGs to plain SVGs
Related commits:
git commit 373e3a6
git commit 6c52a46
bitacovir wrote: pinged by pinger macro
CC @bitacovir
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: TechDraw Icon name/functionality uniformity

Post by bitacovir »

Kunda1 wrote: Wed May 05, 2021 11:59 am This thread tracks the work of
  • Organizing the TechDraw.qrc file (link)
  • Renaming the TechDraw sPixmap variables which are essentially the SVG icon names of each TechDraw function to mirror the name of the function. Or in certain instances changing the function name to accommodate the icon name because it is more appropriate
  • Making sure the sWhatsThis variable mirrors the icon name which will invoke the correct wiki page when using the Std WhatsThis command in the FreeCAD GUI
  • That each TechDraw icon is named in a uniform standard as other workbenches are: <Workbench>_<Function>
    Example: TechDraw_ClipGroupRemove instead of techdraw-ClipGroupRemove or TechDraw_ClipGroup_Remove
  • Converting all Inkscape formatted SVGs to plain SVGs
Ok. Thanks for clarifying the tasks. I will be happy to help.
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: TechDraw Icon name/functionality uniformity

Post by bitacovir »

First PR https://github.com/FreeCAD/FreeCAD/pull/4779
for 11 SVG files: Saved as SVG plain formats and fix names files to following FC convention.
<file>icons/TechDraw_TreeHatch.svg</file>
<file>icons/TechDraw_TreePage.svg</file>
<file>icons/TechDraw_TreePageUnsync.svg</file>
<file>icons/TechDraw_TreePageSync.svg</file>
<file>icons/TechDraw_TreePageTemplate.svg</file>
<file>icons/TechDraw_TreeProjGroup.svg</file>
<file>icons/TechDraw_TreeSection.svg</file>
<file>icons/TechDraw_TreeSpreadsheet.svg</file>
<file>icons/TechDraw_TreeSymbol.svg</file>
<file>icons/TechDraw_TreeView.svg</file>
<file>icons/TechDraw_TreeMulti.svg</file>
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: TechDraw Icon name/functionality uniformity

Post by bitacovir »

Kunda1 wrote: Wed May 05, 2021 11:59 am This thread tracks the work of
I found a svg icon that is not being used in any command....
https://github.com/FreeCAD/FreeCAD/blob ... edecor.svg
Should we just delete it?
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Post Reply