Missing Checkbox_dark and checkbox_indeterminate_dark

A forum for research and development of the user interface of FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
MisterMaker
Posts: 744
Joined: Mon Sep 21, 2020 7:41 am
Contact:

Missing Checkbox_dark and checkbox_indeterminate_dark

Post by MisterMaker »

Was working on my light theme and wanted to do a white checkbox with a black check, but there is no black check while the no-theme version uses a black check.
It should be in: https://github.com/FreeCAD/FreeCAD/tree ... dark-light
This is how it looks with no theme:
Image
But all light theme's color in the checkbox to overcome this issue:
Image
I turned the current white version black, just like Netflix....oh no I am not going there... :lol:
Anyway I think I can just try and push this true Github?
Attachments
checkbox_dark.svg
(1.71 KiB) Downloaded 47 times
checkbox_indeterminate_dark.svg
(3.3 KiB) Downloaded 46 times
User avatar
chennes
Veteran
Posts: 3905
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Missing Checkbox_dark and checkbox_indeterminate_dark

Post by chennes »

Yeah, go ahead and make a PR with these and we'll get it merged.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
MisterMaker
Posts: 744
Joined: Mon Sep 21, 2020 7:41 am
Contact:

Re: Missing Checkbox_dark and checkbox_indeterminate_dark

Post by MisterMaker »

chennes wrote: Sat Oct 22, 2022 9:34 pm Yeah, go ahead and make a PR with these and we'll get it merged.
Done https://github.com/FreeCAD/FreeCAD/pull/7632
User avatar
chennes
Veteran
Posts: 3905
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Missing Checkbox_dark and checkbox_indeterminate_dark

Post by chennes »

Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Missing Checkbox_dark and checkbox_indeterminate_dark

Post by Kunda1 »

Noice!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply