Change inner diameter label placement

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
tpavlicek
Posts: 60
Joined: Sun Jan 07, 2018 2:15 am

Change inner diameter label placement

Post by tpavlicek »

Hello all,

I would like to publish my first FreeCAD code contribution. In the current state, if the TechDraw inner diameter line is not horizontal, it crosses the datum label like on the picture below:
Diameter_current.png
Diameter_current.png (13.38 KiB) Viewed 539 times
From my point of view this is rather unfortunate and thus I am suggesting to place the inner diameter label above the dimension line, respecting the dimesion line tilt. For a better illustration, please see the same situation as above, but using my code changes:
Diameter_suggested.png
Diameter_suggested.png (14.31 KiB) Viewed 539 times
I hope you will find this change useful and it will be possible to integrate it into the master. I have already created the pull request.

Kind regards,


Tomas

PS: Thanks to all contributors for this awesome software!
chrisb
Veteran
Posts: 53933
Joined: Tue Mar 17, 2015 9:14 am

Re: Change inner diameter label placement

Post by chrisb »

Thanks, this seems to be conformant to what is called here DIN EN ISO 3098 standard.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Change inner diameter label placement

Post by wandererfan »

Marvellous! Thank you Tomas. git commit 243aebf2df
Post Reply