Welding Symbol Merged

Discussions about the development of the TechDraw workbench
User avatar
wandererfan
Posts: 3342
Joined: Tue Nov 06, 2012 5:42 pm

Welding Symbol Merged

Postby wandererfan » Fri Aug 23, 2019 12:58 am

The Welding Symbol tool described here has been merged into master branch.

Looking forward to feedback.
chrisb
Posts: 20660
Joined: Tue Mar 17, 2015 9:14 am

Re: Welding Symbol Merged

Postby chrisb » Fri Aug 23, 2019 1:18 am

Thanks! This was the final step to replace Drawing/DrawingDimensioning. Will test when it is in master.

You had asked for welding symbols. Did you have a look at Hamish's? See https://github.com/hamish2014/FreeCAD_d ... ns/welding
User avatar
wandererfan
Posts: 3342
Joined: Tue Nov 06, 2012 5:42 pm

Re: Welding Symbol Merged

Postby wandererfan » Fri Aug 23, 2019 11:54 am

chrisb wrote:
Fri Aug 23, 2019 1:18 am
You had asked for welding symbols. Did you have a look at Hamish's? See https://github.com/hamish2014/FreeCAD_d ... ns/welding
I did. Some alignment issues, size differences and (some of?) Hamish's icons include the leader line. They also have arrow side and other side icons in the same symbol? Could be edited to work of course.

TDvsDDSymbols.png
TDvsDDSymbols.png (8.95 KiB) Viewed 456 times
Jee-Bee
Posts: 1979
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Welding Symbol Merged

Postby Jee-Bee » Fri Aug 23, 2019 12:03 pm

Same workflow as in your screengrab?
  1. create and place leader
  2. define and add welding symbol to leader
compared to:
  1. define weldment symbol and place with leader
chrisb
Posts: 20660
Joined: Tue Mar 17, 2015 9:14 am

Re: Welding Symbol Merged

Postby chrisb » Fri Aug 23, 2019 12:11 pm

This could well be something which non-developers can do. Can you tell us what requirements you have?
User avatar
wandererfan
Posts: 3342
Joined: Tue Nov 06, 2012 5:42 pm

Re: Welding Symbol Merged

Postby wandererfan » Sat Aug 24, 2019 2:43 pm

chrisb wrote:
Fri Aug 23, 2019 12:11 pm
This could well be something which non-developers can do. Can you tell us what requirements you have?
I was hoping somebody would take on the creation of the symbols. :)
TechDraw_WeldingSymbol#Svg_Symbol_Tiles should cover most of it.

The ones I've done are in "...Mod/TechDraw/Symbols/Welding/AWS". My plan is to have ISO symbols (are they much different?) go into "...Mod/TechDraw/Symbols/Welding/ISO". Any other standard could get their own directory.
User avatar
wandererfan
Posts: 3342
Joined: Tue Nov 06, 2012 5:42 pm

Re: Welding Symbol Merged

Postby wandererfan » Sat Aug 24, 2019 2:45 pm

Jee-Bee wrote:
Fri Aug 23, 2019 12:03 pm
Same workflow as in your screengrab?
  1. create and place leader
  2. define and add welding symbol to leader
Yes, this is how it works now. The other way would retire a bit more programming, but could be done if the current method is too awkward.