Collection of TD issues, proposals and ideas for FC 0.19

Discussions about the development of the TechDraw workbench
User avatar
uwestoehr
Posts: 794
Joined: Sun Jan 27, 2019 3:21 am

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby uwestoehr » Mon Nov 04, 2019 11:49 pm

wandererfan wrote:
Mon Nov 04, 2019 1:07 pm
PR 2687 and 2689 have been merged.
Many thanks.

Here is the rather massive PR for the renaming of tools and menus for the Wiki:
PR 2694
Please have a look and directly modify my PR if you see issues. (I set in GitHub that you can modify my PR.)
User avatar
wandererfan
Posts: 3149
Joined: Tue Nov 06, 2012 5:42 pm

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby wandererfan » Tue Nov 05, 2019 12:12 am

uwestoehr wrote:
Mon Nov 04, 2019 11:49 pm
Here is the rather massive PR for the renaming of tools and menus for the Wiki:
Wow. Massive indeed. Thank you!

I won't have much time for review until Wednesday, but a quick peek looks good.
User avatar
uwestoehr
Posts: 794
Joined: Sun Jan 27, 2019 3:21 am

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby uwestoehr » Tue Nov 05, 2019 12:31 am

wandererfan wrote:
Tue Nov 05, 2019 12:12 am
I won't have much time for review until Wednesday, but a quick peek looks good.
I will now be away until Thursday evening. And there is also no hurry. I hope I introduced no troubles, therefore i propose to keep the PR open for a week for proper testing. I also guess that others might like to change a further name are are not confident with a name change. So they have 1 week time to comment.
richie
Posts: 1
Joined: Fri Nov 15, 2019 7:42 pm

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby richie » Fri Nov 15, 2019 8:54 pm

TechDraw Balloon annotation symbol moves when LockPosition is true.

Can anybody confirm same behaviour?
See attached file

Page.View.Balloon.LockPosition

The balloon annotation has a 'Lock Position' property.
Set it to true then save, close and re-open the file.
The shape enclosing the text has moved.
The text remains at it's saved position.

Now set the 'lock position' property to false and recompute.
The circle jumps to it's saved position.
Only occurs when 'lock position' is true.

---------------------------------------------------------
OS: Ubuntu 16.04.6 LTS (KDE//usr/share/xsessions/plasma)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18714 (Git) AppImage
Build type: Release
Branch: master
Hash: a7ad04ba4aefb486fbc5e7c68da3dd488443b08c
Python version: 3.7.3
Qt version: 5.12.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)
Attachments
TD_balloon_lock_position.FCStd
(26.11 KiB) Downloaded 5 times
User avatar
uwestoehr
Posts: 794
Joined: Sun Jan 27, 2019 3:21 am

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby uwestoehr » Sat Nov 16, 2019 8:46 pm

wandererfan wrote:
Tue Nov 05, 2019 12:12 am
.
Hi wandererfan, can you consider to merge my commit? I think it is stable enough and as soon as it is merged, we can fine-tune more tooltiops et.
thanks and regards Uwe
User avatar
uwestoehr
Posts: 794
Joined: Sun Jan 27, 2019 3:21 am

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby uwestoehr » Sat Nov 16, 2019 8:51 pm

richie wrote:
Fri Nov 15, 2019 8:54 pm
TechDraw Balloon annotation symbol moves when LockPosition is true.
Can anybody confirm same behaviour?
Yes, I can confirm with today's master and added it to the list:

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18738 (Git)
Build type: Release
Branch: master
Hash: f65a72deb71e8b2a18c849adc9a900c3d113d51b
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)
User avatar
wandererfan
Posts: 3149
Joined: Tue Nov 06, 2012 5:42 pm

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby wandererfan » Sun Nov 17, 2019 2:08 pm

richie wrote:
Fri Nov 15, 2019 8:54 pm
TechDraw Balloon annotation symbol moves when LockPosition is true.
Continued here.
User avatar
wandererfan
Posts: 3149
Joined: Tue Nov 06, 2012 5:42 pm

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby wandererfan » Sun Nov 17, 2019 2:09 pm

uwestoehr wrote:
Sat Nov 16, 2019 8:46 pm
Hi wandererfan, can you consider to merge my commit? I think it is stable enough and as soon as it is merged, we can fine-tune more tooltiops et.
I merged the one with the conflicts resolved. I think it was up to date with yours, but please check.
User avatar
uwestoehr
Posts: 794
Joined: Sun Jan 27, 2019 3:21 am

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby uwestoehr » Sun Nov 24, 2019 10:20 pm

wandererfan wrote:
Sun Nov 17, 2019 2:09 pm
I merged the one with the conflicts resolved. I think it was up to date with yours, but please check.
Many thanks. Everything looks correct.

I also made a PR to add units to the positions X and Y: https://github.com/FreeCAD/FreeCAD/pull/2734
The problem is that with this patch, I get correctly the units, but existing document with a ProjGroup Front view issuenow this error when clicking on them:

Code: Select all

Unhandled std::exception caught in GUIApplication::notify.
The error message is: Access violation - no RTTI data!
What do I miss? Are there more conversion voids necessary? (I have serious troubles to understand the code because there are so few comments.)
User avatar
wandererfan
Posts: 3149
Joined: Tue Nov 06, 2012 5:42 pm

Re: Collection of TD issues, proposals and ideas for FC 0.19

Postby wandererfan » Mon Nov 25, 2019 1:22 am

uwestoehr wrote:
Sun Nov 24, 2019 10:20 pm

Code: Select all

Unhandled std::exception caught in GUIApplication::notify.
The error message is: Access violation - no RTTI data!
Run Time Type Information would probably involve a dynamic_cast.

If it happens as soon as you double click on the ProjGroup in the tree, then the place to look is ViewProviderProjGroup where it starts the editor.

If it happens as soon as you click on Front in the page display, then it could be in the selection logic in MDiViewPage and that's messy.

I'm a bit backlogged at the moment, but if I get some time I'll look in your github.