[fixed] projection group view is much too large

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

[fixed] projection group view is much too large

Post by uwestoehr »

It seems my recent SVG fix introduced a regression because:
- create a section view of a projection item view

result:

Code: Select all

Error - Could not load hatch into SVG renderer for C:/Users/USti/AppData/Local/Temp/FreeCAD_Doc_69c132b3-fb97-4455-be74-4f8f8e03d450_bb6d8f_6372/FreeCAD_Doc_69c132b3-fb97-4455-be74-4f8f8e03d450_bb6d8f_6372SectionViewSvgHatch.svg
SVG tile count exceeded: 10001
I have no idea yet since all my fix did, was adding missing SVG namespaces.
Last edited by uwestoehr on Fri Feb 14, 2020 3:20 pm, edited 2 times in total.
User avatar
wandererfan
Veteran
Posts: 6326
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [regression] section viwew hatching broken

Post by wandererfan »

uwestoehr wrote: Fri Feb 07, 2020 12:33 am It seems my recent SVG fix introduced a regression because:
Don't think it is your change. 10001 64x64 tiles is a big area. Is the section face large?
User avatar
wandererfan
Veteran
Posts: 6326
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [regression] section viwew hatching broken

Post by wandererfan »

uwestoehr wrote: Fri Feb 07, 2020 12:33 am SVG tile count exceeded: 10001[/code]
Try changing this parameter:

Code: Select all

    hGrp = App::GetApplication().GetUserParameter()
        .GetGroup("BaseApp")->GetGroup("Preferences")->GetGroup("Mod/TechDraw/Decorations");
    m_maxTile = hGrp->GetInt("MaxSVGTile",10000l);
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [regression] section viwew hatching broken

Post by uwestoehr »

wandererfan wrote: Fri Feb 07, 2020 1:23 am Don't think it is your change. 10001 64x64 tiles is a big area. Is the section face large?
OK, there is a different issue with TD.
I see that you set up a new preferences parameter to increase the tile number. But the issue is why this number limit is exceeded.

My test file consists just of a simple block 240 x 80 x 80 mm:
top-joint.FCStd
testfile
(29.31 KiB) Downloaded 16 times

- take this example file and create a Projection Group

result: you get a huge view

- now select a view of the projection group and insert a section view

result: now you get the 10001 tile limit

So the issue is not the section view but the wrong size of the projection group view.
User avatar
wandererfan
Veteran
Posts: 6326
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [regression] section viwew hatching broken

Post by wandererfan »

uwestoehr wrote: Sat Feb 08, 2020 12:20 am My test file consists just of a simple block 240 x 80 x 80 mm:

- take this example file and create a Projection Group

result: you get a huge view
What is the Scale for the Projection group? Here the PG is big, but not huge, at 1:1.
top-joint11.png
top-joint11.png (228.85 KiB) Viewed 851 times
result: now you get the 10001 tile limit
I don't hit the limit event at 8:1.
top-joint_section_81.png
top-joint_section_81.png (105.22 KiB) Viewed 851 times
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [regression] section viwew hatching broken

Post by uwestoehr »

wandererfan wrote: Sat Feb 08, 2020 2:32 pm What is the Scale for the Projection group? Here the PG is big, but not huge, at 1:1.
Good point. I think it is a bug in the preferences, because these are my preferences settings (using todays' master):
preferences settings
preferences settings
FreeCAD_d8SmHLdR23.png (14.35 KiB) Viewed 760 times

and when I create a new projection group view I see this in the dialog:
dialog view
dialog view
FreeCAD_IXmwXrqCOL.png (22.98 KiB) Viewed 760 times

So "auto" scaling sets the scaling to 5:1. I don't know why. These are my parameter settings:
parameter settings
parameter settings
FreeCAD_LsG5s7F3JP.png (58.86 KiB) Viewed 760 times

When I accept the proposed settings of the dialog. I get a Front view. Then I select this Front view and create a section view, and voià:
section view tile exceed
section view tile exceed
FreeCAD_hE1vJBQZYD.png (22.71 KiB) Viewed 760 times
User avatar
wandererfan
Veteran
Posts: 6326
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [regression] section viwew hatching broken

Post by wandererfan »

uwestoehr wrote: Sat Feb 08, 2020 12:20 am So the issue is not the section view but the wrong size of the projection group view.
This commit git commit 3a42205cb4 should fix projection group autoscale .
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [regression] section viwew hatching broken

Post by uwestoehr »

wandererfan wrote: Fri Feb 14, 2020 1:00 pm This commit git commit 3a42205cb4 should fix projection group autoscale .
Many thanks! Works fine.
Post Reply