[Fixed] TechDraw source code RichTextAnnotation artifacts

[Kunda1]

Looks like there is somewhat duplicate code (although commented out) in TD source between Gui/CommandAnnotate.cpp and Gui/CommandDecorate.cpp

https://github.com/FreeCAD/FreeCAD/blob ... #L153-L204
https://github.com/FreeCAD/FreeCAD/blob ... #L136-L194

Is it OK to remove the latter ?
Although the commented out code has some extra code that I wondered could be useful (but it may be just written differently in CommandAnnotate.cpp file. Can someone check please?

[M4x]

Push

[tpavlicek]

From my point of view it is pretty much safe to remove the code from Gui/CommandDecorate.cpp. The additional code lines are rather an artifact from copied and pasted "Add Leader Line" code.

Kind regards,


Tomas

[Kunda1]

I don't have time ATM to do this. Anyone interested in house cleaning this?

[tpavlicek]

Hi,

I have created Pull Request #4904 for the removal.

Kind regards,


Tomas

[kkremitzki]

Merged

[Kunda1]

git commit ed8e632