Looks like there is somewhat duplicate code (although commented out) in TD source between Gui/CommandAnnotate.cpp and Gui/CommandDecorate.cpp
https://github.com/FreeCAD/FreeCAD/blob ... #L153-L204
https://github.com/FreeCAD/FreeCAD/blob ... #L136-L194
Is it OK to remove the latter ?
Although the commented out code has some extra code that I wondered could be useful (but it may be just written differently in CommandAnnotate.cpp file. Can someone check please?
[Fixed] TechDraw source code RichTextAnnotation artifacts
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
[Fixed] TechDraw source code RichTextAnnotation artifacts
Last edited by Kunda1 on Wed Aug 11, 2021 5:15 pm, edited 1 time in total.
Reason: Marked thread [FIXED]
Reason: Marked thread [FIXED]
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: TechDraw source code RichTextAnnotation artifacts
From my point of view it is pretty much safe to remove the code from Gui/CommandDecorate.cpp. The additional code lines are rather an artifact from copied and pasted "Add Leader Line" code.
Kind regards,
Tomas
Kind regards,
Tomas
Re: TechDraw source code RichTextAnnotation artifacts
I don't have time ATM to do this. Anyone interested in house cleaning this?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
- kkremitzki
- Veteran
- Posts: 2518
- Joined: Thu Mar 03, 2016 9:52 pm
- Location: Illinois
Re: [Fixed] TechDraw source code RichTextAnnotation artifacts
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs