[FIXED] Tech Draw → undo button

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
kaktus
Veteran
Posts: 1183
Joined: Sun Aug 11, 2019 11:59 am
Location: opolskie
Contact:

Re: [bug} Tech Draw → undo button

Post by kaktus »

Hi

It's a pleasure to talk to you, I haven't had the chance yet. :D
.
I have prepared a picture description
.
1.png
1.png (73.32 KiB) Viewed 1348 times
2.png
2.png (115.52 KiB) Viewed 1348 times
3.png
3.png (120.65 KiB) Viewed 1348 times
4.png
4.png (130.94 KiB) Viewed 1348 times
.
The model projection disappears after clicking Cancel button...
I also added my model file to the attachments.

Code: Select all

OS: Debian GNU/Linux bookworm/sid (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.28810 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 6f5a5a2)
Hash: 6f5a5a2019c586db63650713de860d3e810739d4
Python 3.9.12, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: Polish/Poland (pl_PL)
Installed mods: 
...
Attachments
szablon_przyciskow.FCStd
(11.03 KiB) Downloaded 23 times
Twórca polskiej wersji Wiki dla FreeCAD, współwórca polskiej wersji GUI.
"Cierpliwym być musisz, by wiedzę zgłębiać tajemną, gdyż ciemna strona mocy niszczącą i silną jest".
User avatar
wandererfan
Veteran
Posts: 6308
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [bug} Tech Draw → undo button

Post by wandererfan »

kaktus wrote: Tue May 10, 2022 7:53 pm The model projection disappears after clicking Cancel button...
If creating the projection was the last action before adding/cancelling the center line then git commit 584af812ad should fix it. The Cancel button code was doing 2 undo steps instead of 1.
User avatar
kaktus
Veteran
Posts: 1183
Joined: Sun Aug 11, 2019 11:59 am
Location: opolskie
Contact:

Re: [bug} Tech Draw → undo button

Post by kaktus »

Thanks for solving the problem quickly.

:mrgreen:

I found a few more "strange behaviors"
E.g. the escaping projection.
Twórca polskiej wersji Wiki dla FreeCAD, współwórca polskiej wersji GUI.
"Cierpliwym być musisz, by wiedzę zgłębiać tajemną, gdyż ciemna strona mocy niszczącą i silną jest".
User avatar
wandererfan
Veteran
Posts: 6308
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [bug} Tech Draw → undo button

Post by wandererfan »

kaktus wrote: Wed May 11, 2022 7:23 pm I found a few more "strange behaviors"
E.g. the escaping projection.
Tell me more please. What is an "escaping projection"?
User avatar
kaktus
Veteran
Posts: 1183
Joined: Sun Aug 11, 2019 11:59 am
Location: opolskie
Contact:

Re: [bug} Tech Draw → undo button

Post by kaktus »

I prepared the video, but forgot to turn off the radio. :roll:

Just in case, turn off the sound when playing. :D

https://vimeo.com/708810750

https://vimeo.com/708812555

When you mark the projection with the mouse he runs away. :lol:

Edit:

It would probably be a good idea to activate all projections and check on each one for this effect.
Twórca polskiej wersji Wiki dla FreeCAD, współwórca polskiej wersji GUI.
"Cierpliwym być musisz, by wiedzę zgłębiać tajemną, gdyż ciemna strona mocy niszczącą i silną jest".
User avatar
wandererfan
Veteran
Posts: 6308
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [bug} Tech Draw → undo button

Post by wandererfan »

kaktus wrote: Wed May 11, 2022 8:13 pm When you mark the projection with the mouse he runs away. :lol:
Do you have this property set to true?
AutoDistribute: If true, space out individual views automatically. Use false to position manually.
Attachments
PGDialog_AutoDistribute.png
PGDialog_AutoDistribute.png (33.28 KiB) Viewed 1164 times
User avatar
kaktus
Veteran
Posts: 1183
Joined: Sun Aug 11, 2019 11:59 am
Location: opolskie
Contact:

Re: [bug} Tech Draw → undo button

Post by kaktus »

All settings are set to default values so yes, this option is checked.

Did you notice that only some of them move when you point the mouse :?:
Regardless of whether this option is checked, I expect all drawing elements to be immobile at pointing.

When this option was unchecked, then all throws already moved after the selection. When this option is checked, only some of them will move.
Right, Front, Left, Rear projections always remain stationary. In my opinion, this is the correct behavior.

Warm greetings.
Twórca polskiej wersji Wiki dla FreeCAD, współwórca polskiej wersji GUI.
"Cierpliwym być musisz, by wiedzę zgłębiać tajemną, gdyż ciemna strona mocy niszczącą i silną jest".
User avatar
kaktus
Veteran
Posts: 1183
Joined: Sun Aug 11, 2019 11:59 am
Location: opolskie
Contact:

Re: [bug} Tech Draw → undo button

Post by kaktus »

Another problem is related to this runaway projection in the drawing.

That's why I'm going to introduce him right away.

This time it concerns the tools:
  • Turn View Frames On/Off
  • Add Leaderline to View
I prepared a video so that I could present my problem more efficiently.

https://vimeo.com/708933535

While drawing the leader line I used the esc key. This happened when I finish drawing the first and third reference lines.
The other actions are clear from the video.
If you have any questions I will be happy to answer them. ;)

Code: Select all

OS: Debian GNU/Linux bookworm/sid (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.28810 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 6f5a5a2)
Hash: 6f5a5a2019c586db63650713de860d3e810739d4
Python 3.9.12, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: Polish/Poland (pl_PL)
Installed mods: 
  * sheetmetal 0.2.49
  * Rocket 2.4.1
  * BIM 2021.12.0
  * Reinforcement
  * Render 2022.1.0
  * MOOC 2022.4.21
  * Plot 2022.4.17
  * Behave-Dark-Colors 0.0.1
  * dodo
Twórca polskiej wersji Wiki dla FreeCAD, współwórca polskiej wersji GUI.
"Cierpliwym być musisz, by wiedzę zgłębiać tajemną, gdyż ciemna strona mocy niszczącą i silną jest".
User avatar
wandererfan
Veteran
Posts: 6308
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [bug} Tech Draw → undo button

Post by wandererfan »

kaktus wrote: Thu May 12, 2022 4:01 am Right, Front, Left, Rear projections always remain stationary. In my opinion, this is the correct behavior.
Moving Front moves the whole group. Right, Left and Rear move only horizontally. Top and Bottom only move vertically. The 4 angled projections can move anywhere.

You can use the LockPosition property to prevent a projection from moving even if AutoDistribute is true.
User avatar
wandererfan
Veteran
Posts: 6308
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [bug} Tech Draw → undo button

Post by wandererfan »

kaktus wrote: Thu May 12, 2022 4:48 am This time it concerns the tools:
  • Turn View Frames On/Off
  • Add Leaderline to View
What is the issue with the Leaderline, please? I can't figure it out from the video.

I know about the views moving when the frames are toggled, but I don't have a nice fix for that yet.
Post Reply