[fixed] CommandExtensionPack compiler warnings

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

[fixed] CommandExtensionPack compiler warnings

Post by uwestoehr »

The MSVC compiler shows me these warnings with today's master:

Code: Select all

43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(137,48): warning C4305: 'argument': truncation from 'double' to 'float'
43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(139,47): warning C4305: 'argument': truncation from 'double' to 'float'
43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(194,52): warning C4305: 'argument': truncation from 'double' to 'float'
43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(247,51): warning C4305: 'argument': truncation from 'double' to 'float'
43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(300,49): warning C4305: 'argument': truncation from 'double' to 'float'
43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(353,48): warning C4305: 'argument': truncation from 'double' to 'float'
43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(393,42): warning C4305: 'argument': truncation from 'double' to 'float'
43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(432,46): warning C4305: 'argument': truncation from 'double' to 'float'
43>D:\FreeCAD-git\src\Mod\TechDraw\Gui\CommandExtensionPack.cpp(433,46): warning C4305: 'argument': truncation from 'double' to 'float'
I will have a look when I find time in a few days, or maybe another one could make a quick PR.

tpavlicek wrote: .
wmayer
Founder
Posts: 20241
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: CommandExtensionPack compiler warnings

Post by wmayer »

edi
Posts: 481
Joined: Fri Jan 17, 2020 1:32 pm

Re: CommandExtensionPack compiler warnings

Post by edi »

Thanks to both. I will include this in the ongoing development. Meanwhile I have coded 5 more tools.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: CommandExtensionPack compiler warnings

Post by uwestoehr »

wmayer wrote: Mon Oct 11, 2021 2:47 pm git commit fbdb4e29d8
Thanks.
Post Reply