Regression in TaskSelectLineAttributes.ui

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Regression in TaskSelectLineAttributes.ui

Post by Roy_043 »

A recent commit has reverted many textual improvements in the TaskSelectLineAttributes.ui file. Seems as if a rebase was skipped.
https://github.com/FreeCAD/FreeCAD/comm ... 4205d42d67
edi wrote: pinged by pinger macro
Can you look at this please. Thanks.
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Regression in TaskSelectLineAttributes.ui

Post by wandererfan »

I picked up an old version of TaskDimension.ui while doing this PR https://github.com/FreeCAD/FreeCAD/pull/5441. This looks like a similar issue.

Haven't been able to figure out what happened yet.

This git commit f2d624cede from Jan 07 has the correct text and this one git commit 242dcd7e44 reverts the text to the original.
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Regression in TaskSelectLineAttributes.ui

Post by Roy_043 »

wandererfan wrote: Thu Jan 27, 2022 3:18 pm Haven't been able to figure out what happened yet.
Roy_043 wrote: Thu Jan 27, 2022 11:36 am Seems as if a rebase was skipped.
:mrgreen:

Is there a way to fix this 'automagically', or does someone have to do this 'by hand'?
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Regression in TaskSelectLineAttributes.ui

Post by wandererfan »

Roy_043 wrote: Wed Feb 02, 2022 11:13 am Is there a way to fix this 'automagically', or does someone have to do this 'by hand'?
My magic wand needs recharging. If it is just a case of setting the ui file back to where it was before the commit, then we can check out the previous version, save the ui file, check out the current version, replace the ui file and commit. If there are changes to the ui file mixed in with the regression to the previous version, then it is a "by hand" job.
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Regression in TaskSelectLineAttributes.ui

Post by Roy_043 »

'by hand' it is then.
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Regression in TaskSelectLineAttributes.ui

Post by Roy_043 »

User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Regression in TaskSelectLineAttributes.ui

Post by Roy_043 »

Merged.
Post Reply