LGTM TechDraw Warnings

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

LGTM TechDraw Warnings

Post by Kunda1 »

@wandererfan can you take a look at this warning when you get a chance?
https://lgtm.com/projects/g/FreeCAD/Fre ... 2163210742
Screenshot_20220630_141322.png
Screenshot_20220630_141322.png (124.37 KiB) Viewed 639 times
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: LGTM TechDraw Warnings

Post by Kunda1 »

bump
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: LGTM TechDraw Warnings

Post by wandererfan »

Kunda1 wrote: Mon Jul 04, 2022 11:17 ambump
It's done when it's done.

I'm surprised that it is only complaining about gp_Ax2. Call by value is rampant in TD.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: LGTM TechDraw Warnings

Post by Kunda1 »

wandererfan wrote: Mon Jul 04, 2022 3:07 pm
Kunda1 wrote: Mon Jul 04, 2022 11:17 ambump
It's done when it's done.

I'm surprised that it is only complaining about gp_Ax2. Call by value is rampant in TD.
Of course! :mrgreen:
Just didn't see you acknowledge. Thanks for responding.

Shall i open a ticket to track this?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply