TechDraw Multithread Testing

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Syres
Veteran
Posts: 2891
Joined: Thu Aug 09, 2018 11:14 am

Re: Multithread Testing

Post by Syres »

wandererfan wrote: Fri Aug 12, 2022 2:35 pm I'm probably using v2.6 since my OCC version is 7.6.2. I can download and build from v2.7 if it is significant.
That's fine, all sounds good, thanks again.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Multithread Testing

Post by Kunda1 »

@wandererfan if you want to re-trigger the experimental snap build, you can just iterate the BUILD_ME parameter
in https://github.com/FreeCAD/FreeCAD-snap ... t.yaml#L86

Here' s the branch you can push to: https://github.com/FreeCAD/FreeCAD-snap ... ad-testing
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
wandererfan
Veteran
Posts: 6238
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Multithread Testing

Post by wandererfan »

I haven't heard any feedback from Windows (or mac) users, but this works on my Windows10 VM, so I guess it is ready to go into master.

Speak up if you have issues.
chrisb
Veteran
Posts: 53785
Joined: Tue Mar 17, 2015 9:14 am

Re: Multithread Testing

Post by chrisb »

wandererfan wrote: Tue Aug 16, 2022 5:48 pm I haven't heard any feedback from Windows (or mac) users, but this works on my Windows10 VM, so I guess it is ready to go into master.
I will mac test if it is in master. No self compilation here.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Multithread Testing

Post by Kunda1 »

Unfortunately, pushing to master it the least ideal but most optimal way to get testers :lol: :roll: :cry:
Eventually we'll have a service where we can build cross-platform experimental builds per PR (not just Linux Snap for the time being)
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
-alex-
Veteran
Posts: 1849
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: Multithread Testing

Post by -alex- »

Thanks for the great job done here, much appreciated, furthermore as my tiny Raspberry Pi 4 is concerned :D

Seems to works fine here:

Code: Select all

OS: Debian GNU/Linux 10 (buster) (LXDE/LXDE-pi)
Word size of FreeCAD: 64-bit
Version: 0.21.30084 (Git)
Build type: Unknown
Branch: hlrThreadrc1
Hash: 0df187d22876bc2e5516ff86d52b1da3a74938ff
Python 3.7.3, Qt 5.11.3, Coin 4.0.0a, Vtk 7.1.1, OCC 7.3.0
Locale: French/France (fr_FR)
About the test46_multithreading_section.FCStd file, on my Pi4-4GB:
(565/3359Mo of RAM used)

- file loading:
- Master: 6,50mn
- hlrThreadrc1: 2,08mn (3,4x)
- TechDraw_RedrawPage:
- Master: 3,38mn
- hlrThreadrc1: 2,04mn (1,8x)
2mn
CPU load reach 100% during 1.25mn, then approx. 25% up to 2mn.

Thanks again @wandererfan for this great enhancement :D

PS: a 3 views ArchDetail example file takes 16s to redraw.
2022-08-17-185936_1920x1080_scrot.png
2022-08-17-185936_1920x1080_scrot.png (80.21 KiB) Viewed 1182 times
user1234
Veteran
Posts: 3261
Joined: Mon Jul 11, 2016 5:08 pm

Re: Multithread Testing

Post by user1234 »

Kunda1 wrote: Tue Aug 16, 2022 6:42 pm Unfortunately, pushing to master it the least ideal but most optimal way to get testers
Since in other OS seems to work, why not? Also this is the reason, why we have a master branch and daily build. It is not the case here that it is highly experimental, i might just work on a few OS not imminently. Also who runs the daily build, must know about the risk, that a few days it can happen that thinks break. Also the development needs that feedback (the lack of it because it is not in the daily build, is the reason why it might not work on a few OS).

Greetings
user1234
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Multithread Testing

Post by Kunda1 »

@user1234 my subtle point was hinting that we should provide a more robust solution for experimental cross-platform builds of PRs such as this. The barrier for entry for testers is self-compiling these branches. In the future, it would be most ideal if we could provide Snap, AppImage, Flatpak, macOS, Windows on-demand builds that can be retriggered depending on the discretion of the PR dev (for example, not every commit should trigger all new builds).
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
user1234
Veteran
Posts: 3261
Joined: Mon Jul 11, 2016 5:08 pm

Re: Multithread Testing

Post by user1234 »

Kunda1 wrote: Wed Aug 17, 2022 7:21 pm my subtle point was hinting that we should provide a more robust solution for experimental cross-platform builds of PRs such as this. The barrier for entry for testers is self-compiling these branches. In the future, it would be most ideal if we could provide Snap, AppImage, Flatpak, macOS, Windows on-demand builds that can be retriggered depending on the discretion of the PR dev (for example, not every commit should trigger all new builds).
That is fine, but the problem is, will people do download this? Even for the most early adopters, that is not that case, at least i do not think so. But maybe i am totally wrong.

Greetings
user1234
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Multithread Testing

Post by Kunda1 »

user1234 wrote: Wed Aug 17, 2022 7:39 pm But maybe i am totally wrong.
I hear you but I subscribe to the 'If you build it they will come'.
Especially if we provide easy to install experimental builds, we'll have a lot more testers than we do now.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply