[Solved] _TaskPanelCfdSolverControl.py Typo

A subforum specific to the development of the OpenFoam-based workbenches ( Cfd https://github.com/qingfengxia/Cfd and CfdOF https://github.com/jaheyns/CfdOF )

Moderator: oliveroxtoby

Syres
Posts: 286
Joined: Thu Aug 09, 2018 11:14 am

[Solved] _TaskPanelCfdSolverControl.py Typo

Postby Syres » Thu Apr 18, 2019 9:41 am

Updated CfdOF Wb an hour ago along with updating CfMesh and HiSA, I've found a typo in _TaskPanelCfdSolverControl.py which causes the following error when double-clicking OpenFOAM in the tree:

Code: Select all

Traceback (most recent call last):
  File "C:\Users\JPS\AppData\Roaming\FreeCAD\Mod\CfdOF\_ViewProviderCfdSolverFoam.py", line 84, in setEdit
    taskd = _TaskPanelCfdSolverControl(foamRunnable)
  File "C:\Users\JPS\AppData\Roaming\FreeCAD\Mod\CfdOF\_TaskPanelCfdSolverControl.py", line 73, in __init__
    self.open_paraview = CfdconsoleProcess()
<class 'NameError'>: name 'CfdconsoleProcess' is not defined

_TaskPanelCfdSolverControl.py
Just appears to be lowercase 'c' needs making capital 'C' on line 73, from:

Code: Select all

        self.open_paraview = CfdconsoleProcess()
To

Code: Select all

        self.open_paraview = CfdConsoleProcess()
Last edited by Syres on Thu Apr 18, 2019 4:33 pm, edited 1 time in total.
nic
Posts: 18
Joined: Thu Apr 18, 2019 1:14 pm
Location: France

Re: [Regression] _TaskPanelCfdSolverControl.py Typo

Postby nic » Thu Apr 18, 2019 1:43 pm

Bug confirmed on freecad 0.18 (conda)

Code: Select all

OS: Ubuntu 18.10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14555 (Git shallow)
Build type: Release
Branch: (HEAD detached at 2ea4c6a)
Hash: 2ea4c6a81a6449b6880f8a757d0298dd889e0630
Python version: 3.7.1
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/Switzerland (fr_CH)
I made a pull request:

https://github.com/jaheyns/CfdOF/pull/17
User avatar
Kunda1
Posts: 4778
Joined: Thu Jan 05, 2017 9:03 pm

Re: [Regression] _TaskPanelCfdSolverControl.py Typo

Postby Kunda1 » Thu Apr 18, 2019 3:39 pm

Has been fixed by dev in https://github.com/jaheyns/CfdOF/commit ... 4bb81236b8
Please mark this thread as [SOLVED] by editing the first post summary, Thanks!
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
Syres
Posts: 286
Joined: Thu Aug 09, 2018 11:14 am

Re: [Solved] _TaskPanelCfdSolverControl.py Typo

Postby Syres » Thu Apr 18, 2019 4:34 pm

Thanks Oliver and @nic.