Material improvements

A forum to discuss the implementation of a good Materials system in FreeCAD
User avatar
bernd
Posts: 8317
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Material improvements

Postby bernd » Mon Apr 29, 2019 7:48 pm

https://github.com/FreeCAD/FreeCAD/pull/2102 see git commit 3651b9b8 add basic card handling. Far far from your development but much better than we had.

If you find a minute it still would be cool to get it at least working without crash.

bernd
Erni24
Posts: 13
Joined: Fri Feb 24, 2017 6:00 pm

Re: Material improvements

Postby Erni24 » Fri Aug 09, 2019 9:24 pm

I tried compiling the Material fork too. The compiling rebased to upstream worked well for Python3 and Qt5.
But starting the application results in a crash in PropertyPartMaterial.cpp in function SolidMaterialArray::init_type()

1) Py::PropertyPartMaterial ::init_type(); from Application.cpp
2) SolidMaterialArray::init_type(); line 423 from PropertyPartMaterial.cpp
3) behaviors().readyType(); line 321 from PropertyPartMaterial.cpp

Because the coupling C++ to Python is new to me, I have to discover this for a while...

Dietmar

Code: Select all

Program received signal SIGSEGV, Segmentation fault.
#0  /lib/x86_64-linux-gnu/libc.so.6(+0x37840) [0x7f7a29a44840]
#1  /lib/x86_64-linux-gnu/libpython3.7m.so.1.0(PyTuple_New+0xf7) [0x7f7a2c12e427]
#2  /lib/x86_64-linux-gnu/libpython3.7m.so.1.0(PyType_Ready+0x1ab2) [0x7f7a2bf8eb62]
#3  /lib/x86_64-linux-gnu/libpython3.7m.so.1.0(PyType_Ready+0x1ee8) [0x7f7a2bf8ef98]
#4  0x7f7a2c90dd7e in Py::PythonType::readyType() from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADBase.so+0x1c
#5  0x7f7a2d2c494e in Py::SolidMaterialArray::init_type() from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADApp.so+0x69
#6  0x7f7a2d2c43d0 in Py::PropertyPartMaterial::init_type() from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADApp.so+0x16
#7  0x7f7a2d313480 in App::Application::initTypes() from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADApp.so+0x1a0
#8  0x7f7a2d31329b in App::Application::init(int, char**) from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADApp.so+0x35
#9  /home/dietmar/Code/FreeCAD/freecad-build-master/bin/FreeCAD(main+0x6b8) [0x562b10108cb7]
#10  /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7f7a29a3109b]
#11  /home/dietmar/Code/FreeCAD/freecad-build-master/bin/FreeCAD(_start+0x2a) [0x562b101084ca]
*** Beendet mit Rückgabewert: 01 ***
User avatar
bernd
Posts: 8317
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Material improvements

Postby bernd » Sun Aug 11, 2019 6:56 pm

Since I am a Python guy I am not of a big help here. That is the main reason nothing has been fixed in this branch, because IMHO the would be a big step forward in materials in FreeCAD.

Best to do is to encapsulate the problem and ask a specific question in developer part of the forum. For sure I will help with testing if you would do further developing.

bernd
Erni24
Posts: 13
Joined: Fri Feb 24, 2017 6:00 pm

Re: Material improvements

Postby Erni24 » Mon Aug 12, 2019 7:24 pm

Ok, I will do so
User avatar
bernd
Posts: 8317
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Material improvements

Postby bernd » Mon Aug 19, 2019 5:21 am

The big App::Link merge has taken place. On rebase I get merge conflicts in a few files:

Code: Select all

       von beiden geändert:    src/App/DynamicProperty.cpp
        von beiden geändert:    src/App/DynamicProperty.h
        von beiden geändert:    src/App/Property.h
        von beiden geändert:    src/App/PropertyExpressionEngine.cpp
        von beiden geändert:    src/App/PropertyStandard.cpp
        von beiden geändert:    src/Mod/Spreadsheet/App/Cell.cpp
If you are still on this it might makes sense to rebase to up to date master.
Erni24
Posts: 13
Joined: Fri Feb 24, 2017 6:00 pm

Re: Material improvements

Postby Erni24 » Fri Aug 23, 2019 4:40 pm

Something for this weekend...
eivindkvedalen
Posts: 597
Joined: Tue Jan 29, 2013 10:35 pm

Re: Material improvements

Postby eivindkvedalen » Fri Aug 23, 2019 6:05 pm

bernd wrote:
Mon Aug 19, 2019 5:21 am
The big App::Link merge has taken place. On rebase I get merge conflicts in a few files:

Code: Select all

       von beiden geändert:    src/App/DynamicProperty.cpp
        von beiden geändert:    src/App/DynamicProperty.h
        von beiden geändert:    src/App/Property.h
        von beiden geändert:    src/App/PropertyExpressionEngine.cpp
        von beiden geändert:    src/App/PropertyStandard.cpp
        von beiden geändert:    src/Mod/Spreadsheet/App/Cell.cpp
If you are still on this it might makes sense to rebase to up to date master.
I managed to compile it on a rebased master today.

Eivind
User avatar
bernd
Posts: 8317
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Material improvements

Postby bernd » Wed Aug 28, 2019 10:45 am

:) wow which branch on https://github.com/eivindkv/FreeCAD? On Py2 or Py3?

How about this ?

eivindkvedalen wrote:
Tue Apr 02, 2019 6:54 pm
bernd wrote:
Tue Apr 02, 2019 5:16 pm
with Python2 and Qt5 I am able to compile this branch. But as soon as an object which has a Shape property is created FreeCAD crashes. Files with meshes or for example an FEM file without the shape saves and reopens fine.
I discovered that as well, and I'm looking into it now...

Eivind
User avatar
Kunda1
Posts: 5458
Joined: Thu Jan 05, 2017 9:03 pm

Re: Material improvements

Postby Kunda1 » Wed Aug 28, 2019 5:19 pm

eivindkvedalen wrote:
Fri Aug 23, 2019 6:05 pm
Off-topic, but just wanted to say, Nice to see you :wave:
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
eivindkvedalen
Posts: 597
Joined: Tue Jan 29, 2013 10:35 pm

Re: Material improvements

Postby eivindkvedalen » Fri Sep 06, 2019 7:05 pm

Kunda1 wrote:
Wed Aug 28, 2019 5:19 pm
eivindkvedalen wrote:
Fri Aug 23, 2019 6:05 pm
Off-topic, but just wanted to say, Nice to see you :wave:
:wave: :D

Eivind