bernd wrote: ↑
Wed Feb 20, 2019 5:21 am
A PR could change this ...
I found the culprit. You did run the script without the existing cards. Best is to run the script in source directory. Thus it takes the card meta informations from the existing cards.
Then this should be corrected. I purposely used an empty folder to generate the cards from scratch by avoiding any interferences.
I think there must be a way to generate the cards from scratch.
Besides this, I use Github for different projects and there I can e.g. go to https://github.com/FreeCAD/FreeCAD/tree ... rdMaterial
and then press "upload files" to make a PR using many different changed files. Why is this not allowed for FC?
I would like to hear if my work was correct since i also changed in my PR these things:
- consistently use the dot as decimal separator. because I have seen that in the .ods file sometimes the comma was used, sometimes the dot. The correct decimal separator for the file and the CSV should be documented somehow in the .ods file.
- I added a source URL, because I find it important for the user to see where the values come from. I miss this source URL for all other material cards
- you added to my new cards that you are the copyright holder. It is not necessary that you use me now, but to check if we really can apply a copyright. I mean we are using property values from different sources and thus cannot apply our copyrigth because we cannot check if this is allowed. For the source I used it is allowed to use the values under a free license but i don't know about the existing material cards.
- use https if possible. This should also be documented somehow in the .ods file.