Missing data in material cards

A forum to discuss the implementation of a good Materials system in FreeCAD
User avatar
uwestoehr
Posts: 777
Joined: Sun Jan 27, 2019 3:21 am

Missing data in material cards

Postby uwestoehr » Wed Feb 20, 2019 1:36 am

- open material dialog
- select there the material card for ABS

result:

Code: Select all

ThermalConductivity not found in material data of: ABS
ThermalExpansionCoefficient not found in material data of: ABS
SpecificHeat not found in material data of: ABS
I get the same for all other material cards except of Calculix-steel and steel-generic.

OS: Windows 7
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15938 (Git)
Build type: Release
Branch: master
Hash: acdd4b097bbaf6d94bc09cf38f25924bd5d3e778
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: German/Germany (de_DE)
User avatar
bernd
Posts: 8468
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Missing data in material cards

Postby bernd » Wed Feb 20, 2019 5:21 am

This is because the data is missing ... https://github.com/FreeCAD/FreeCAD/blob ... /ABS.FCMat

A PR could change this ... ;)

There is an libre office calc file which makes it much easier to edit mat cards See https://github.com/FreeCAD/FreeCAD/blob ... erials.ods You need to run a Linux bash script to create mat cards from it. AFAIK you are on Windows. If you would provide an edited ods I could create the mat cards too.
User avatar
uwestoehr
Posts: 777
Joined: Sun Jan 27, 2019 3:21 am

Re: Missing data in material cards

Postby uwestoehr » Wed Feb 20, 2019 11:00 am

bernd wrote:
Wed Feb 20, 2019 5:21 am
A PR could change this ... ;)
See https://github.com/FreeCAD/FreeCAD/blob ... erials.ods
I would do this, however, in the FC Windows builds most files in
https://github.com/FreeCAD/FreeCAD/tree ... rdMaterial
are missing, also the .ods file.

I reported this yesterday:
https://forum.freecadweb.org/viewtopic. ... 25#p288035
Should I open a bug report to assure this will be included in FC 0.18 final?
User avatar
bernd
Posts: 8468
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Missing data in material cards

Postby bernd » Wed Feb 20, 2019 1:55 pm

https://forum.freecadweb.org/viewtopic. ... 25#p288125

the ods you can get from github sources ...
User avatar
uwestoehr
Posts: 777
Joined: Sun Jan 27, 2019 3:21 am

Re: Missing data in material cards

Postby uwestoehr » Thu Feb 21, 2019 1:19 am

bernd wrote:
Wed Feb 20, 2019 5:21 am
A PR could change this ... ;)
Here it is: https://github.com/FreeCAD/FreeCAD/pull/1983

Unfortunately I cannot just upload the different FCMat files to make a quick PR with all files. Therefore please find the files in this ZIP:
Material.zip
(95.44 KiB) Downloaded 27 times
I did not only add the missing properties but also added the basic plastic materials:
- Polyamide 6
- PVC
- PET
- PP
- PET

I did not add PE since it is available in too many very different forms.
User avatar
uwestoehr
Posts: 777
Joined: Sun Jan 27, 2019 3:21 am

Re: Missing data in material cards

Postby uwestoehr » Thu Feb 21, 2019 11:23 am

bernd wrote:
Wed Feb 20, 2019 5:21 am
A PR could change this ... ;)
...
I found the culprit. You did run the script without the existing cards. Best is to run the script in source directory. Thus it takes the card meta informations from the existing cards.
Then this should be corrected. I purposely used an empty folder to generate the cards from scratch by avoiding any interferences.
I think there must be a way to generate the cards from scratch.

Besides this, I use Github for different projects and there I can e.g. go to https://github.com/FreeCAD/FreeCAD/tree ... rdMaterial and then press "upload files" to make a PR using many different changed files. Why is this not allowed for FC?

I would like to hear if my work was correct since i also changed in my PR these things:
- consistently use the dot as decimal separator. because I have seen that in the .ods file sometimes the comma was used, sometimes the dot. The correct decimal separator for the file and the CSV should be documented somehow in the .ods file.
- I added a source URL, because I find it important for the user to see where the values come from. I miss this source URL for all other material cards
- you added to my new cards that you are the copyright holder. It is not necessary that you use me now, but to check if we really can apply a copyright. I mean we are using property values from different sources and thus cannot apply our copyrigth because we cannot check if this is allowed. For the source I used it is allowed to use the values under a free license but i don't know about the existing material cards.
- use https if possible. This should also be documented somehow in the .ods file.
Last edited by uwestoehr on Thu Feb 21, 2019 11:36 am, edited 1 time in total.
User avatar
bernd
Posts: 8468
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Missing data in material cards

Postby bernd » Thu Feb 21, 2019 12:03 pm

FULLACK for a way to create the cards from scratch and with windows too. This means a switch to Python, IMHO. I started some dev in this regard as well as in the regard of duplicate mat card parser code already. But this will not go into 0.18 version.

I the regard of your license questions. They makes sense to ask, but I can not answer them because I do not have the knowledge to to ... ATM

May be yorik can help here ... see post before my post ...
yorik wrote: ping
User avatar
uwestoehr
Posts: 777
Joined: Sun Jan 27, 2019 3:21 am

Re: Missing data in material cards

Postby uwestoehr » Thu Feb 21, 2019 5:43 pm

bernd wrote:
Thu Feb 21, 2019 12:03 pm
I see now that I made a mistake:
I wanted to change the polymer cards to "-Generic" to make clear that uers don't think this are THE material properties for e.g. PLA. Now we have 2 material cards for PLA. Could you please remove the one for PLA, because PLA-Generic superseeds it?
For ABS and Acrylic Glass can you please rename the cards to "ABS-Generic", respectively?

Sorry and thanks Uwe
User avatar
bernd
Posts: 8468
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Missing data in material cards

Postby bernd » Thu Feb 21, 2019 6:42 pm

uwestoehr wrote:
Thu Feb 21, 2019 5:43 pm
bernd wrote:
Thu Feb 21, 2019 12:03 pm
I see now that I made a mistake:
I wanted to change the polymer cards to "-Generic" to make clear that uers don't think this are THE material properties for e.g. PLA. Now we have 2 material cards for PLA. Could you please remove the one for PLA, because PLA-Generic superseeds it?
For ABS and Acrylic Glass can you please rename the cards to "ABS-Generic", respectively?

Sorry and thanks Uwe
would you check this before I go for a PR ? https://github.com/berndhahnebach/FreeC ... /bhbdev196
User avatar
uwestoehr
Posts: 777
Joined: Sun Jan 27, 2019 3:21 am

Re: Missing data in material cards

Postby uwestoehr » Thu Feb 21, 2019 8:03 pm

bernd wrote:
Thu Feb 21, 2019 6:42 pm
would you check this before I go for a PR ? https://github.com/berndhahnebach/FreeC ... /bhbdev196
Many thanks! The changes look good.

Sorry again for the trouble.