current implementation of find_package(Coin3D)

Having trouble installing or compiling FreeCAD? Get help here.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
reox
Posts: 929
Joined: Sat Aug 13, 2016 10:06 am
Contact:

current implementation of find_package(Coin3D)

Post by reox »

I'm not sure if this is a problem but I found that the current implementation of find_package(Coin3D) will run into the manual search even if cmake files for coin are available (for example on debian sid).

For me, https://github.com/FreeCAD/FreeCAD/blob ... .cmake#L80 just prints out:

Code: Select all

-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29") 
-- Checking for module 'Coin'
--   No package 'Coin' found
but does not set COIN3D_FOUND, thus the next lines will be active, falling back into manual search which is not necessary.

I think the first line in FindCoind3D.cmake should be something like:

Code: Select all

find_package(Coin3D)
if(NOT COIN3D_FOUND)
    # Do the manual search...
Post Reply