Win Conda based build failure

Having trouble installing or compiling FreeCAD? Get help here.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Win Conda based build failure

Post by sgrogan »

Using Conda as a package manager, I get the following when using External SMesh

Code: Select all

1>c:\users\username\github\freecad\src\mod\fem\app\PreCompiled.h(125): fatal error C1083: Cannot open include file: 'StdMeshers_TrianglePreference.hxx': No such file or directory
Indeed the file doesn't exist in my conda env, it does exist in FreeCAD's 3rd party salomemesh.

Any suggestions?

Code: Select all

// Version Number
#define FCVersionMajor "0"
#define FCVersionMinor "19"
#define FCVersionName  "Vulcan"
// test: $Format:Hash (%H), Date: %ci$
#define FCRevision      "16784 (Git)"      //Highest committed revision number
#define FCRevisionDate  "2019/05/16 20:15:36"     //Date of highest committed revision
#define FCRepositoryURL "git://github.com/FreeCAD/FreeCAD.git master"      //Repository URL of the working copy

// Git relevant stuff
#define FCRepositoryHash   "ec5720d51c54e6c433cacf207e773aad09dbb25c"
#define FCRepositoryBranch "master"
"fight the good fight"
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Win Conda based build failure

Post by looo »

reproduced on all ci's used for conda-packages:
https://ci.appveyor.com/project/looooo/ ... 0823#L3041
https://circleci.com/gh/looooo/freecad-feedstock/229
https://circleci.com/gh/looooo/freecad-feedstock/230

I guess the check here somehow is not working:
https://github.com/FreeCAD/FreeCAD/blob ... led.h#L125

This was added in this commit.

edit: Maybe this is missing?

Code: Select all

#ifdef HAVE_SMESH
#include <SMESH_Version.h>
#endif
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Win Conda based build failure

Post by looo »

I tried this patch: https://github.com/looooo/freecad-feeds ... sion.patch
but it seems to work only for windows. Any ideas what I did wrong?
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Win Conda based build failure

Post by sgrogan »

looo wrote: Fri May 17, 2019 6:40 pm Any ideas what I did wrong?
Thanks for looking into this.
As far as I understand the PreCompiled.h files are only used on win. Maybe this needs to be in the .cpp file?
I don't understand how the whole thing works but I know wmayer and abdullah have been extending the PCH https://devblogs.microsoft.com/cppblog/ ... endations/ stuff to speed Win compilation time.
"fight the good fight"
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Win Conda based build failure

Post by looo »

Thanks. With some modification to the order of the headers this worked now.
PR: https://github.com/FreeCAD/FreeCAD/pull/2185
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Win Conda based build failure

Post by sgrogan »

looo wrote: Sat May 18, 2019 1:01 pm With some modification to the order of the headers this worked now.
Thanks looo!
"fight the good fight"
User avatar
easyw-fc
Veteran
Posts: 3629
Joined: Thu Jul 09, 2015 9:34 am

Re: Win Conda based build failure

Post by easyw-fc »

Hi,
is building Win Conda still an issue?
I cannot found recent Win Conda releases for FC 0.18.2 and 0.19dev
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Win Conda based build failure

Post by looo »

I am doing weekly builds of freecad (as conda-packages) since quite some time. So therefor it's still an issue. I guess once the crashes on osx are solved working on an alternative to appimage/dmg for windows makes much sense.

btw.: This was a problem with external smesh in general.
Post Reply