Improve GNU install directories with cmake

Having trouble installing or compiling FreeCAD? Get help here.
wmayer
Site Admin
Posts: 15000
Joined: Thu Feb 19, 2009 10:32 am

Improve GNU install directories with cmake

Postby wmayer » Wed Jul 10, 2019 11:29 am

Recently we again had build problems because of some issues with absolute vs. relative path names on some Linux machines due to using some cmake variables in a non-standard way. In the past we had this discussion several times but never really fixed the issue. So, I created a branch to follow the ideas and suggestions of these discussions.

Here are some links to the resources I found:
https://forum.freecadweb.org/viewtopic. ... 4&p=168308
https://forum.freecadweb.org/viewtopic. ... 1&start=10
https://forum.freecadweb.org/viewtopic. ... 6&p=253866
https://github.com/FreeCAD/FreeCAD/pull/617/files
https://wiki.debian.org/Multiarch/Implementation#CMake
https://www.gnu.org/prep/standards/html ... ables.html

And here the link to the branch:
https://github.com/FreeCAD/FreeCAD/pull/2318
kkremitzki wrote: ping
Can you have a look please and check if the Debian packages still work as expected with these changes?
User avatar
Kunda1
Posts: 5949
Joined: Thu Jan 05, 2017 9:03 pm

Re: Improve GNU install directories with cmake

Postby Kunda1 » Wed Jul 10, 2019 11:45 am

Should probably link to this in the Packaging subforum (or perhaps pin it)?
OR could I move this topic to the Packaging subforum and leave a shadow topic in this one?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
kkremitzki
Posts: 1796
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Improve GNU install directories with cmake

Postby kkremitzki » Tue Aug 13, 2019 6:55 pm

Ah, let me take a look tonight and see if this will break anything.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
kkremitzki
Posts: 1796
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Improve GNU install directories with cmake

Postby kkremitzki » Tue Aug 20, 2019 3:36 am

Alright, this will result in a packaging change but I'm ready, go ahead and merge whenever.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
wmayer
Site Admin
Posts: 15000
Joined: Thu Feb 19, 2009 10:32 am

Re: Improve GNU install directories with cmake

Postby wmayer » Thu Aug 22, 2019 3:15 pm

OK, I have merged it right now.

Btw, since you are also the maintainer of the shiboken2 package I want to report an error. None of the shiboken2 packages provide the file shiboken2.so, only libshiboken2.so is provided.

FYI, these are two different files used for different purposes. shiboken2.so is the Python extension module and libshiboken2.so is the shared library needed to link against shiboken2 via C++.

Remark: The real file names contain a platform specific suffix and e.g. look like shiboken2.cpython-36m-x86_64-linux-gnu.so or libshiboken2.cpython-36m-x86_64-linux-gnu.so

I remember a discussion with you and Normand where he thought that the one file is superfluous and thus should not be picked up by the packaging tools but this assumption is wrong.
User avatar
kkremitzki
Posts: 1796
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Improve GNU install directories with cmake

Postby kkremitzki » Sun Aug 25, 2019 9:47 pm

At least as far as Debian is concerned I am not technically a maintainer and I've only worked with the package a bit, but it looks like I'll have to work on updating it soon anyway, so I'll investigate the issue.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
wmayer
Site Admin
Posts: 15000
Joined: Thu Feb 19, 2009 10:32 am

Re: Improve GNU install directories with cmake

Postby wmayer » Mon Aug 26, 2019 9:12 am

Thanks.
User avatar
kkremitzki
Posts: 1796
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Improve GNU install directories with cmake

Postby kkremitzki » Mon Aug 26, 2019 10:51 am

I looked into it and the build process is creating the file but just not doing anything with it. The solution is to modify debian/control to add a declaration for a python-shiboken2 and python3-shiboken2 package, and then add debian/*.install files for those two to grab the shiboken2.*.so files. However because this creates a new binary package it will have to go through the sometimes lengthy NEW queue in Debian. In the meantime I can try to upload builds including this package to our PPAs.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
cron