Error after upgrading (freecad daily)

[gneiss]

Hi,

the following error shows up after I upgrade freecad today:

Code: Select all

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/share/freecad-daily/Mod/Show/__init__.py", line 3, in <module>
    from .TempoVis import TempoVis
  File "/usr/share/freecad-daily/Mod/Show/TempoVis.py", line 26, in <module>
    from .ShowUtils import is3DObject
<class 'ModuleNotFoundError'>: No module named 'Show.ShowUtils'
ViewProviderSketch::setEdit: could not import Show module. Visibility automation will not work.

[kkremitzki]

Same issue as in https://forum.freecadweb.org/viewtopic.php?f=3&t=39211

[vocx]

Same issue as in https://forum.freecadweb.org/viewtopic.php?f=3&t=39211

Code: Select all

ls /usr/lib/freecad-daily/Mod/Show/
Containers.py  DepGraphTools.py  __init__.py  TempoVis.py

I think this problem is different. According to my system, there is no ShowUtils.py file in the daily build. Maybe it's an issue with packaging (salsa.debian and so on)?

Compiled from source all files seem to be there

Code: Select all

ls /opt/freecad-build-vocx/Mod/Show/
Containers.py     FrozenClass.py  __pycache__     SceneDetails  TempoVis.py    TVStack.py
DepGraphTools.py  __init__.py     SceneDetail.py  ShowUtils.py  TVObserver.py

[gneiss]

Maybe it's an issue with packaging

Yes, I think so.
On an other PC, I don't have the file ShowUtils.py, too.
But on this PC the error didn't came up ??

Here are the infomations of the PC without the error:
OS: Ubuntu 14.04.6 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.16093 (Git)
Build type: Release
Branch: releases/FreeCAD-0-18
Hash: 690774c0effe4fd7b8d2b5e2fb2b8c8d145e21ce
Python version: 2.7.6
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)

I will send the infos of the PC with error this evening, when I am back at home...

[vocx]

...
On an other PC, I don't have the file ShowUtils.py, too.
But on this PC the error didn't came up ??

Here are the infomations of the PC without the error:
...
Version: 0.18.16093 (Git)
...

This is an old version of FreeCAD (the stable 0.18 release), so obviously you won't see the problem here.

The current error is due to some code that was changed in the current master (the TempoVis.py file), so it will only affect the development version 0.19.

[gneiss]

1. Sorry for the late answer, I didn't have acess to the other PC till now.
Below are the informations of the PC with error.

@vocx:
Yes, You are right, the 1. one is Version .18 ???
I have to check why I don't have .19 on the 1. PC, or maybe I have both there one as an appimage and the one from freecad daily...
Seams that the symbolic link was still pointing to the appimage (have to check thsi).

@All:
On the PC with error, I got an update today, but:
- the system information didn't change (unfortunally the build number is not shown inside info "copy to clipboard").
- the errror still exist (the missing file ws not included with the upgrade

[vocx]

...Maybe it's an issue with packaging (salsa.debian and so on)?...

Regarding this issue of packaging, I have submitted pull request #17 to the Debian-salsa repository, with the missing lines in the installation file. Hopefully this solves the issue of missing IFC files, missing TempoVis files, etc. in the freecad-daily packages.

If I understand this correctly, the freecad-daily-runtime.install file must be kept up to date in order for the Debian and Ubuntu packages to be created without problems.

[drmacro]

Hi,

I have the latest daily...I think. At least apt update says all are up to date.

But I still get this when I try to create a sketch:

Code: Select all

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/share/freecad-daily/Mod/Show/__init__.py", line 3, in <module>
    from .TempoVis import TempoVis
  File "/usr/share/freecad-daily/Mod/Show/TempoVis.py", line 26, in <module>
    from .ShowUtils import is3DObject
<class 'ModuleNotFoundError'>: No module named 'Show.ShowUtils'
ViewProviderSketch::setEdit: could not import Show module. Visibility automation will not work.

Is there something I can/need to do to get the daily working again?



OS: Ubuntu 19.04 (XFCE/ubuntustudio)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.7.3
Qt version: 5.12.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)

[vocx]

...
Is there something I can/need to do to get the daily working again?

I suggest we ping Kremitzki so that he merges my request. That hopefully solves the issue. See above.

ping

[kkremitzki]

...Maybe it's an issue with packaging (salsa.debian and so on)?...

Regarding this issue of packaging, I have submitted pull request #17 to the Debian-salsa repository, with the missing lines in the installation file. Hopefully this solves the issue of missing IFC files, missing TempoVis files, etc. in the freecad-daily packages.

If I understand this correctly, the freecad-daily-runtime.install file must be kept up to date in order for the Debian and Ubuntu packages to be created without problems.

Thanks for making the PR! These debian/*.install files just happen to list the files one-by-one because the tool I use to list missing stuff from the package installation does that. It would be better in the long run, when modifications need to be made, rather than add a new line "path/to/new/file/foo.py", to add a new line "path/to/new/file/*.py" and remove any other line referencing a specific Python file "path/to/new/file/bar.py". Once that's done, any new or deleted Python files in that directory won't require additional changes, a change will be needed only when someone adds a new directory which contains Python files.