Fail compile on Fedora 28

[nahshon]

Recent changes use properties that are available only in QT5.
in src/Mod/Sketcher/Gui/TaskSketcherGeneral.ui:

Code: Select all

4607cbb9cf      (  donovaly     2019-09-23 02:00:40 +0200       139)     <property name="sizeAdjustPolicy">
4607cbb9cf      (  donovaly     2019-09-23 02:00:40 +0200       140)      <enum>QAbstractScrollArea::AdjustToContents</enum>
4607cbb9cf      (  donovaly     2019-09-23 02:00:40 +0200       141)     </property>

According to Third_Party_Libraries:
Version: 4.1 or higher

According to cmake (cMake/FreeCAD_Helpers/SetupQt.cmake)
set(QT_MIN_VERSION 4.5.0)

[vocx]

Recent changes use properties that are available only in QT5.
...

I just noticed this as well. The Travis compilation is failing for GCC, Python 2 and Qt4. See the thread Sketcher task dialog.

[uwestoehr]

According to cmake (cMake/FreeCAD_Helpers/SetupQt.cmake)
set(QT_MIN_VERSION 4.5.0)

See my reply: https://forum.freecadweb.org/viewtopic. ... 57#p338057

I vote to drop Qt4 support for the reason to focus on the needs of the vast majority of users and to safe developer's spare time.

[nahshon]

Thanks @vocx.

I vote to drop Qt4 support for the reason to focus on the needs of the vast majority of users and to safe developer's spare time.

Would that also mean enforcing Python3 and PySide2? That would force me to upgrade from Fedora 28 (no pyside2).
I will try Fedora 30 on VirtualBox first. Anyone can help with the cmake command line for Qt4 + Python3?

[sgrogan]

Anyone can help with the cmake command line for Qt4 + Python3?

I think you should just have to add -DPYTHON_EXECUTABLE="path to Py3 executable" to whatever your using for QT4/PY2
Watch for pivy errors, on Ubuntu @looo patched pivy for PY3.
Also make sure you have python packages with compiled extensions installed for PY3, numpy comes to mind.

[vocx]

Would that also mean enforcing Python3 and PySide2? That would force me to upgrade from Fedora 28 (no pyside2).
I will try Fedora 30 on VirtualBox first. Anyone can help with the cmake command line for Qt4 + Python3?

I don't know Fedora, or their release schedules, but my impression is that 28 is very outdated anyway. I don't know when you are supposed to update. For example, in Ubuntu each long term version is released every two years, so staying with a version for two years is perfectly fine.

As for the compilation this is the regular command that I use.

Code: Select all

cmake -DBUILD_QT5=ON -DPYTHON_EXECUTABLE=/usr/bin/python3 -DCMAKE_BUILD_TYPE=Release ../freecad-source-vocx && make -j3

Maybe just disabling the first option would work, assuming that you have all the Qt4 requisites, of course.

Code: Select all

cmake -DBUILD_QT5=OFF -DPYTHON_EXECUTABLE=/usr/bin/python3 -DCMAKE_BUILD_TYPE=Release ../freecad-source-vocx && make -j3

See CompileOnUnix.

[nahshon]

I don't know Fedora, or their release schedules, but my impression is that 28 is very outdated anyway. I don't know when you are supposed to update. For example, in Ubuntu each long term version is released every two years, so staying with a version for two years is perfectly fine.

Fedora 28 was released on May 2018. There is a new release about every 6 months. Fedora 31 is expected in the end of this months.

As for the compilation this is the regular command that I use.

Code: Select all

cmake -DBUILD_QT5=ON -DPYTHON_EXECUTABLE=/usr/bin/python3 -DCMAKE_BUILD_TYPE=Release ../freecad-source-vocx && make -j3

I'm evaluating Fedora 30 in VirtualBox before doing the actual upgrade. Just managed to compile and run FreeCad for the first time using options similar to yours. (my previous attempts have failed).