Addonmanager problems

[chennes]

This is an artifact of using the QTextEdit widget to display the README -- it should work properly when using the QWebEngineView, if you have time to test there's a draft PR up at https://github.com/FreeCAD/FreeCAD/pull/5413

[kisolre]

there's a draft PR

I tried your branch directly and it worked but I was wandering if at least the left navigation column could be omitted. Wasn't there a forum thread for that?

[chennes]

I think I can manage to hide the <div id="mw-panel"> from the FreeCAD Wiki by injecting some JavaScript into the page -- is that what you mean? (Actually, now that I think about it, I wonder if I can make the page on GitHub auto-scroll to the beginning of the README, too)

[kisolre]

is that what you mean?

Yes, all this is not needed:

[chennes]

I just pushed a commit to that PR that should take care of that - give it a go and see if it's what you're thinking of.

[kisolre]

give it a go and see if it's what you're thinking of.

That compiles and works nicely. Workbenches could also benefit from that jump to the relevant position in the page. And probably some progress bar indicator...

[chennes]

Workbenches could also benefit from that jump to the relevant position in the page. And probably some progress bar indicator...

I agree on both counts -- I've almost got the scroll-to-top thing working for GitHub pages, but it's not as straightforward as the Wiki was. The current ugly label thing is just there because I can't get the WebView to clear itself while it's loading, so it still shows the last page you visited until the data comes in. It's very annoying!

[kisolre]

README.md is not retrieved if the default branch is "main" instead of "master" at least on GitLab:

Code: Select all

https://gitlab.com/sanguinariojoe/freecad.xray/-/blob/master/README.md

Code: Select all

OS: Windows 8.1 Version 6.3 (Build 9600)
Word size of FreeCAD: 64-bit
Version: 0.20.27570 (Git)
Build type: Release
Branch: master
Hash: a46592d45ad146d2a42af313311779775d57838c
Python 3.8.8, Qt 5.15.2, Coin 4.0.1, OCC 7.5.3
Locale: Bulgarian/Bulgaria (bg_BG)
Installed mods: 
  * .stfolder
  * .stignore
  * 3DfindIT 1.2.0
  * A2plus 0.4.54b
  * AirPlaneDesign 0.4.0
  * ArchTextures
  * Assembly4 0.11.9
  * Autoload
  * BIM 2021.12.0
  * BOLTSFC
  * CfdOF 1.9.6
  * CubeMenu
  * CurvedShapes 1.0.0
  * Curves 0.3.0
  * CycloidGearBox
  * Defeaturing
  * Design456
  * DesignSPHysics 0.6.1-2201-31-01
  * dodo
  * DynamicData 2.32.0
  * ExplodedAssembly
  * ExtMan
  * fasteners 0.3.38
  * FCGear
  * FCPDWorkbench 0.2.0
  * FEM_FrontISTR
  * frame
  * freecad.xray
  * FreeCAD_ExtMan
  * FreeCAD_mcm_addon
  * InvGears 0.1.2
  * kicadStepUpMod 10.10.4
  * Launcher
  * Manipulator
  * Mechatronic
  * MeshRemodel 1.8918.0
  * MnesarcoUtils
  * Nikra-DAP
  * nurbs
  * OpticsWorkbench 1.0.7
  * ose-piping
  * parts_library
  * Plot
  * Pyramids-and-Polyhedrons
  * Reinforcement
  * Render 2022.1.0
  * Rocket 2.2.2
  * SearchBar
  * SelectorToolbar
  * sheetmetal 0.2.49
  * Ship
  * Silk
  * SlopedPlanesMacro
  * StemfieWB
  * symbols_library
  * ThreadProfile 1.80.0
  * toSketch
  * workfeature

[chennes]

Make sure if you're using a custom repository that you set the branch:

Screenshot 2022-02-17 174955.png (4.14 KiB) Viewed 1677 times

[kisolre]

That works. But since there is all that "branch selection" code couldn't this be automated to retrieve, store and use the name of the default branch?