[Fixed]Build fails with todays source

Having trouble installing or compiling FreeCAD? Get help here.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
drmacro
Veteran
Posts: 8870
Joined: Sun Mar 02, 2014 4:35 pm

[Fixed]Build fails with todays source

Post by drmacro »

Build fails with git pull this morning.

Pointers on how to fix?

Code: Select all

/home/mac/freecad-source/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp: In member function ‘void PartDesignGui::TaskExtrudeParameters::setCheckboxes(PartDesignGui::TaskExtrudeParameters::Modes, PartDesignGui::TaskExtrudeParameters::Type)’:
/home/mac/freecad-source/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp:414:40: error: no match for ‘operator&&’ (operand types are ‘bool’ and ‘PartDesignGui::TaskExtrudeParameters::Type’)
     else if (mode == Modes::ThroughAll && type = Type::Pocket) {
              ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/home/mac/freecad-source/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp:414:40: note: candidate: ‘operator&&(bool, bool)’ <built-in>
/home/mac/freecad-source/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp:414:40: note:   no known conversion for argument 2 from ‘PartDesignGui::TaskExtrudeParameters::Type’ to ‘bool’
make[2]: *** [src/Mod/PartDesign/Gui/CMakeFiles/PartDesignGui.dir/build.make:457: src/Mod/PartDesign/Gui/CMakeFiles/PartDesignGui.dir/TaskExtrudeParameters.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3079: src/Mod/PartDesign/Gui/CMakeFiles/PartDesignGui.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 93%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskRobotMessages.cpp.o
[ 96%] Built target TechDrawGui
[ 96%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskRobotControl.cpp.o
[ 96%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TrajectorySimulate.cpp.o
[ 96%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskEdge2TracParameter.cpp.o
[ 96%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskTrajectoryDressUpParameter.cpp.o
[ 96%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskWatcher.cpp.o
[ 96%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskDlgSimulate.cpp.o
[ 96%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskDlgEdge2Trac.cpp.o
[ 97%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskDlgTrajectoryCompound.cpp.o
[ 97%] Building CXX object src/Mod/Robot/Gui/CMakeFiles/RobotGui.dir/TaskDlgTrajectoryDressUp.cpp.o
[ 97%] Linking CXX shared library ../../../../Mod/Robot/RobotGui.so
[ 97%] Built target RobotGui
make: *** [Makefile:130: all] Error 2
Cleaned out CMakeCache.txt and then fails eleswhere.

Code: Select all

[ 94%] Building CXX object src/Mod/PartDesign/Gui/CMakeFiles/PartDesignGui.dir/ViewProviderPad.cpp.o
/home/mac/freecad-source/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp: In member function ‘void PartDesignGui::TaskExtrudeParameters::setCheckboxes(PartDesignGui::TaskExtrudeParameters::Modes, PartDesignGui::TaskExtrudeParameters::Type)’:
/home/mac/freecad-source/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp:414:40: error: no match for ‘operator&&’ (operand types are ‘bool’ and ‘PartDesignGui::TaskExtrudeParameters::Type’)
     else if (mode == Modes::ThroughAll && type = Type::Pocket) {
              ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/home/mac/freecad-source/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp:414:40: note: candidate: ‘operator&&(bool, bool)’ <built-in>
/home/mac/freecad-source/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp:414:40: note:   no known conversion for argument 2 from ‘PartDesignGui::TaskExtrudeParameters::Type’ to ‘bool’
make[2]: *** [src/Mod/PartDesign/Gui/CMakeFiles/PartDesignGui.dir/build.make:457: src/Mod/PartDesign/Gui/CMakeFiles/PartDesignGui.dir/TaskExtrudeParameters.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 94%] Automatic MOC for target TechDrawGui
[ 94%] Built target TechDrawGui_autogen
[ 94%] Linking CXX shared library ../../../../Mod/TechDraw/TechDrawGui.so
[ 97%] Built target TechDrawGui
make[1]: *** [CMakeFiles/Makefile2:3079: src/Mod/PartDesign/Gui/CMakeFiles/PartDesignGui.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
Similar error after completely emptying the build directory.
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
clytle374
Posts: 172
Joined: Wed Nov 06, 2013 3:58 am

Re: Build fails with todays source

Post by clytle374 »

Exact same failure on current git running gentoo.
Thanks, Cory
User avatar
chennes
Veteran
Posts: 3884
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Build fails with todays source

Post by chennes »

I think @uwestoehr was working on that.
uwestoehr wrote: .
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
clytle374
Posts: 172
Joined: Wed Nov 06, 2013 3:58 am

Re: Build fails with todays source

Post by clytle374 »

Here is the output of git bisect

Code: Select all

ory@cory ~/sources/freecad-source-testing $ git bisect good
66864bbe7bfeada1522fc8a0055aab1a40a3c24c is the first bad commit
commit 66864b 7bf da1522fc8a0055aab1a40a3c24c
Author: Uwe <donovaly@users.noreply.github.com>
Date:   Sat Jan 8 01:59:58 2022 +0100

    [PD] Pad/Pocket: sort out duplicated code
    
    the checkboxes are almost identical and it avoids work to have them in one location

 src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp | 80 +++++++++++++++++++++++-
 src/Mod/PartDesign/Gui/TaskExtrudeParameters.h   | 14 +++++
 src/Mod/PartDesign/Gui/TaskPadParameters.cpp     | 66 +------------------
 src/Mod/PartDesign/Gui/TaskPadParameters.h       |  8 ---
 src/Mod/PartDesign/Gui/TaskPocketParameters.cpp  | 76 +---------------------
 src/Mod/PartDesign/Gui/TaskPocketParameters.h    |  8 ---
 6 files changed, 96 insertions(+), 156 deletions(-)

clytle374
Posts: 172
Joined: Wed Nov 06, 2013 3:58 am

Re: Build fails with todays source

Post by clytle374 »

chennes wrote: Fri Jan 14, 2022 3:10 pm I think @uwestoehr was working on that.
uwestoehr wrote: .
Should I file a bug report?
Thanks, Cory
User avatar
chennes
Veteran
Posts: 3884
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Build fails with todays source

Post by chennes »

No point, it's "noisier" to post here and ping him on the post (which I did). He'll see this when he has a minute. I'm sure @wmayer can also see what's wrong, I think he created the data structure Uwe's using there.
wmayer wrote: Ping.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
chennes
Veteran
Posts: 3884
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Build fails with todays source

Post by chennes »

That said, I'd bet a lot that the problem is that

Code: Select all

type = Type::Pocket
should be

Code: Select all

type == Type::Pocket
Classic error.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
chennes
Veteran
Posts: 3884
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Build fails with todays source

Post by chennes »

Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
drmacro
Veteran
Posts: 8870
Joined: Sun Mar 02, 2014 4:35 pm

Re: Build fails with todays source

Post by drmacro »

Was that in TaskExtrudeParameters.cpp?

I see an + there in the pull.
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
drmacro
Veteran
Posts: 8870
Joined: Sun Mar 02, 2014 4:35 pm

Re: Build fails with todays source

Post by drmacro »

drmacro wrote: Fri Jan 14, 2022 3:52 pm
Was that in TaskExtrudeParameters.cpp?

I see an + there in the pull.
That does seem to have fixed it.

Off to do my other builds... ;)
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
Post Reply