old TempoVis.py in recent builds

This subforum is specifically to discuss packaging issues on different platforms (windows, mac, linux), and using different packaging systems (conda, etc...)
User avatar
DeepSOIC
Posts: 7166
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

old TempoVis.py in recent builds

Postby DeepSOIC » Mon Sep 23, 2019 8:56 pm

Hi!
I've just downloaded FreeCAD_0.19.18272_x64_LP_12.1.2_PY3QT5-WinVS2015.7z to check. In Mod/Show, there are both TempoVis.py and mTempoVis.py. The former should not be there, it was renamed in git commit aa14a176f74e477d907d5daa2fbd8dc4970eb2e8 (rev. 18216). Any ideas why it's still there?

It doesn't seem to cause problems... mostly, except (possibly) here: https://forum.freecadweb.org/viewtopic. ... 33#p336096
User avatar
sgrogan
Posts: 5473
Joined: Wed Oct 22, 2014 5:02 pm

Re: old TempoVis.py in recent builds

Postby sgrogan » Mon Sep 23, 2019 9:06 pm

DeepSOIC wrote:
Mon Sep 23, 2019 8:56 pm
Any ideas why it's still there?
Bad packaging? :oops:
Should be fixed in the next builds.

Code: Select all

https://github.com/FreeCAD/FreeCAD/releases/download/0.19_pre/FreeCAD_0.19.18284_x64_LP_12.1.2_PY3QT5-WinVS2015.7z
User avatar
DeepSOIC
Posts: 7166
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: old TempoVis.py in recent builds

Postby DeepSOIC » Mon Sep 23, 2019 9:54 pm

sgrogan wrote:
Mon Sep 23, 2019 9:06 pm
Bad packaging?
Well, I have that problem in my build too. It is not unexpected.
Maybe I should add some line to cmake to wipe the file out in build directory?
User avatar
sgrogan
Posts: 5473
Joined: Wed Oct 22, 2014 5:02 pm

Re: old TempoVis.py in recent builds

Postby sgrogan » Mon Sep 23, 2019 10:05 pm

DeepSOIC wrote:
Mon Sep 23, 2019 9:54 pm
Maybe I should add some line to cmake to wipe the file out in build directory?
That's probably a maintenance nightmare. I think it's up to the packager. For the CI engines it's not a problem because they create scratch builds. For Win the CI engines are slow so I package Win locally. I take advantage of incremental builds as often as possible.
User avatar
Kunda1
Posts: 5937
Joined: Thu Jan 05, 2017 9:03 pm

Re: old TempoVis.py in recent builds

Postby Kunda1 » Wed Sep 25, 2019 8:19 pm

Is this issue resolved yet ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
DeepSOIC
Posts: 7166
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: old TempoVis.py in recent builds

Postby DeepSOIC » Fri Oct 04, 2019 7:45 pm

Another error that is likely caused by the presence of the old file: https://forum.freecadweb.org/viewtopic. ... 39#p338539
User avatar
sgrogan
Posts: 5473
Joined: Wed Oct 22, 2014 5:02 pm

Re: old TempoVis.py in recent builds

Postby sgrogan » Fri Oct 04, 2019 8:47 pm

DeepSOIC wrote:
Fri Oct 04, 2019 7:45 pm
Another error that is likely caused by the presence of the old file: https://forum.freecadweb.org/viewtopic. ... 39#p338539
Looks like stuff is missing https://salsa.debian.org/science-team/f ... stall#L484
vocx
Posts: 1897
Joined: Thu Oct 18, 2018 9:18 pm

Re: old TempoVis.py in recent builds

Postby vocx » Fri Oct 04, 2019 9:13 pm

sgrogan wrote:
Fri Oct 04, 2019 8:47 pm
Looks like stuff is missing https://salsa.debian.org/science-team/f ... stall#L484
For some reason Kremitzki removed a bunch of files that I had added, and which are in fact present

https://salsa.debian.org/science-team/f ... 382a254e8a

By the way, FEM renamed a bunch of files in the meantime, but this was after my pull request, so they need to be re-added with their new names.
kkremitzki wrote: ping
Last edited by vocx on Fri Oct 04, 2019 11:21 pm, edited 1 time in total.
User avatar
sgrogan
Posts: 5473
Joined: Wed Oct 22, 2014 5:02 pm

Re: old TempoVis.py in recent builds

Postby sgrogan » Fri Oct 04, 2019 10:00 pm

We need something like the atttached. I'm at line 49 of the "fixes"
freecad-daily-runtime.install.txt
(16.81 KiB) Downloaded 16 times
fake .txt, remove the .txt
User avatar
kkremitzki
Posts: 1796
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: old TempoVis.py in recent builds

Postby kkremitzki » Fri Oct 04, 2019 10:02 pm

vocx wrote:
Fri Oct 04, 2019 9:13 pm
sgrogan wrote:
Fri Oct 04, 2019 8:47 pm
Looks like stuff is missing https://salsa.debian.org/science-team/f ... stall#L484
For some reason Kremitzki removed a bunch of files that I had added, and which are in fact present
I removed those because, in my testing trying to fix the builds, I was getting errors about them not being present. There's a bug somewhere screwing with all this.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.