Good! I did find everything. Now, before creating a Pull Request from your github web page, you probably want to reorder a bit your commits: they will be included in the main BIM Workbench tree, so we want them to be more tidy, while at the moment you have:
Code: Select all
25ed5ba (HEAD -> bim_super_library, ABeton/bim_super_library) Naming fix (# this is a fix commit, not useful to have it in the BIM WB commit history) d9ea66b Added save before link and link links root objects now (# this is a fix commit, not useful to have it in the BIM WB commit history) 2416c1a Bad naming fix (# this is a fix commit, not useful to have it in the BIM WB commit history) 2ac2f6b Library with preview and link. (# two different changes are contained in this commit: preview and link, better to split them) db0017f (origin/master, origin/HEAD, ABeton/master, master) Created horizontal and vertical dimension tools (here starts the BIM Workbench tree) 82b287b Added Leader command db39545 Updated translations ce49e84 Updated translation scripts
- a commit for library preview
- a commit for the link option
if you want to try that you could check this link: https://github.com/FreeCAD/FreeCAD/pull ... -846960544
but at the moment probably you could open a PR (Pull Request) to gather yorik suggestions too...matthijskooijman wrote:Basic approach
Given that most of these changes are pretty independent, the basic workflow I would choose here is to:
Reset you branch back to the original master commit you started working from. The default "mixed" flavor of the git reset command resets your branch and the index/staging area but not the working copy, so this would put you in a position where you would have been if you had done all the coding in your checkout, but not committed any of it yet. On the commandline, this would be git reset origin/master (assuming that you origin/master still points to the commit you branched off from, if not you might need to rebase first, or replace origin/master with the SHA of the branch-off point).
Now, you can use interactive staging to select a subset of all your changes and create a new commit for that. You can do this for each commit to be created in turn. On the commandline, you would use git add -p for this, but I suspect that in kraken you can do a similar thing in e.g. a diff view where you select lines of the diff to be staged. On the commandline you can even edit the to-be-staged diff in a text editor (useful in case you need to commit one change in a line but not another, or in adjacent lines), but if Kraken doesn't support this, and you'd need it, you can always just revert one of the changes in the file manually, commit that, ^Z in your editor and commit the other change.
Note that especially the git add -p / interactive staging is IMHO a very powerful tool, which allows me to have a much improved workflow where I can (in a lot of cases) just focus on coding and making things work first, and then still be able to split the changes in proper commits at a later stage (sometimes at the end, somethings I already commit things halfway when I'm confident that a particular change is somewhat complete and will be included in the final history).
That's good to meI made changes to this, what it does now is that when you press link it first asks you to save the file("Save as") I think it is best to save the file in a folder where you are doing the project and not the library, because it would bloat the library really fast. When you save in this way, it remembers in which folder you saved last time and when you try to link consecutive times, it opens the same folder every time. If you use the "Save" option than it again saves to the library folder.
Are you sure Groups can't be linked?Also the "Link" command selects all the root files of a document and links them. The result is similar to "Insert" command, but the problem is that some objects can't be linked(like Groups for example).
I probably agree, but take into account that this won't be easy, and since FreeCAD is "pure anarchy" I the task will be quite challenging. Expecially because also FreeCAD changes in time, so maybe a deep restructuring that fits FreeCAD 0.20 would not fit FreeCAD 0.37... In my opinion better to have a flexible way to handle different document structures... since I do not think a standardization of the library could be in the mood of Yorik, but i'd like to hear what does he thinksThis brings me to the next point. We should establish rules that would define how should users add their objects to the library. So for example the final object can only be a Part object, or some Arch object in case of architecture objects. These is just of the top of my head, but when we agree on all the rules, we should put them in the wiki perhaps, and when someone wants to add objects to the library, they should follow those rules.
This would be useful indeed, maybe with the help of a script this can be automated for all library documents without having to do it by hand?This is also important because of the image preview that you mentioned before. The image preview works(in the Library object macro, which is another macro), but only if the users saved the thumbnail image while they were saving the file. To activate this option it is necessary to go to Edit/Preferences/General/Document and tick the "Save thumnail into project file when saving document". Also I would set the image size to 256 or even 512 so we have a good quality thumnail.
Oh, I see, yes, indeed we are quite far away!I study Industrial design in Bari, but I finished architecture before. If your location is correct I think we are on different ends of the country
Edit: By the way, I was trying to open the 20ft-container from Logistics/Shipping Containers/20ftISOContainer... and it completely stuck FC... can you have a look? is it too heavy?
Aaand... where do I find the options to turn off the preview?