// Check that the upToFace does not intersect the sketch face and
// is not parallel to the extrusion direction (for simplicity, supportface is used instead of sketchshape)
BRepAdaptor_Surface adapt1(TopoDS::Face(supportface));
BRepAdaptor_Surface adapt2(TopoDS::Face(upToFace));
if (adapt2.GetType() == GeomAbs_Plane) {
if (adapt1.Plane().Axis().IsNormal(adapt2.Plane().Axis(), Precision::Confusion()))
throw Base::ValueError("SketchBased: Up to face: Must not be parallel to extrusion direction!");
}
Thanks. However this PR deletes too much. The check that the distance between the sketch and the face must stay. The error message is however wrong.
Also since the face "adapt1" is no longer necessary, the face "adapt2" must be renamed.
While testing I also found another bug: the Reverse checkbox has no effect on "upToFace" and must therefore be disabled.
uwestoehr wrote: ↑Fri Dec 02, 2022 6:37 pm
While testing I also found another bug: the Reverse checkbox has no effect on "upToFace" and must therefore be disabled.
No I think we had enabled this on purpose before after we found it was sometimes needed, it's important when the face could be a limit on both sides of the profile, see this example, the pad gos up to the inner cylinder face and can be reversed.
Can you maybe add a comment in the code or even better a test script so that this isn't changed in the future by someone else? I can see how one can easily think this option doesn't make sense there.