Kunda1 wrote: ↑
Sat Jul 11, 2020 1:02 pm
Great work! When do you think you will start sending PRs to Fasteners workbench?
I want to add a usable compliment of inch based fasteners to the WB before I make a PR. The ToDo list looks something like this:
-2 slotted screw styles
-3ish styles of cross recessed screws
-Nuts, washers, and screwtap/die tools
I also need to dig into the countersinking and diameter matching functionality to make that work with non-metric diameters.
shaise wrote: ↑
Sat Jul 11, 2020 3:01 pm
Regarding inch fasteners, these can be great upgrade. Should be in a separate code file, though, to not break the integration with Ulrich's code.
Hmm. currently I have just been adding into the screw_maker file. However, I would say that I have not actually broken the integration with Ulrich's code so far. For example, I was able to bring my fork in line with the recent changes to nut thread generation with minimal effort (see https://github.com/slowinternets/FreeCA ... 8c99b52d32
). What about the additional types of fasteners (ISO 402X, ISO 7379, DIN 7984) that have already been added on top of the screw_maker macro? At your option, I can rework the changes to interfere less with the macro, but it isn't my preference.