Fasteners workbench based on screw-maker

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Fasteners workbench based on screw-maker

Post by Kunda1 »

shaise wrote: Wed Mar 31, 2021 5:38 am
Kunda1 wrote: Wed Mar 31, 2021 2:46 am Added
Fasteners_Flip
Fasteners_Move
Anyone want to check?
Looks correct to me. Thanks!
The Properties section of each page I think is wrong.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Fastener WB, clicking on "Counter Sunk" hangs FreeCAD

Post by Kunda1 »

Qutub Abro wrote: Wed Mar 31, 2021 12:59 am I have FreeCAD V0.19 installed. I used "Fastener WB" to make a counter sunk hole in my FreeCAD design. But when I click on the Diameter to change it to M4, The FreeCAD hangs.

Fastener WB was working fine on FreeCAD V0.18.
Can anyone else reproduce this ?


Edit: I merged this from a separate post
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
jmaustpc
Veteran
Posts: 11207
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Fastener WB, clicking on "Counter Sunk" hangs FreeCAD

Post by jmaustpc »

Qutub Abro wrote: Wed Mar 31, 2021 12:59 am I have FreeCAD V0.19 installed. I used "Fastener WB" to make a counter sunk hole in my FreeCAD design. But when I click on the Diameter to change it to M4, The FreeCAD hangs.

Fastener WB was working fine on FreeCAD V0.18.
Why not just use the PartDesign Hole feature?

Here is a M4 course threaded and thread modeled countersunk hole feature in a Pad, just as a simple demo.
Screenshot_20210401_105002.png
Screenshot_20210401_105002.png (39.52 KiB) Viewed 2988 times
jmaustpc
Veteran
Posts: 11207
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Fasteners workbench based on screw-maker

Post by jmaustpc »

hpbmo wrote: Wed Mar 31, 2021 11:04 am Here it works with FASTENERSWB_VERSION = 'V0.3.32'



OS: Windows 10 Version 2004
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24276 (Git)
Build type: Release
Branch: releases/FreeCAD-0-19
Hash: a88db11e0a908f6e38f92bfc5187b13ebe470438
Python version: 3.8.6+
Qt version: 5.15.1
Coin version: 4.0.1
OCC version: 7.5.0
Locale: German/Switzerland (de_CH)
not really since the hole is now not part of the Body.
jmaustpc
Veteran
Posts: 11207
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Fasteners workbench based on screw-maker

Post by jmaustpc »

Here is the file, I toggled "Model Thread" property to "false" to make the file small enough to upload here. Just toggle it to "true" if you want to 3d print the thread or similar.
you can see the property in the property editor in combo view in this screen shot.
Screenshot_20210401_110730.png
Screenshot_20210401_110730.png (26.03 KiB) Viewed 2984 times
jmaustpc
Veteran
Posts: 11207
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Fasteners workbench based on screw-maker

Post by jmaustpc »

Here is the same file as above but with the Model thread property toggled to true.
Qutub Abro
Posts: 2
Joined: Thu Feb 18, 2021 4:08 am

Re: Fasteners workbench based on screw-maker

Post by Qutub Abro »

Thanks for the quick reply.
Here is more information about what happened and what I did to overcome it.
Fastener WB had been working fine for me since I installed it about couple of weeks back, on FreeCAD 0.18.4
I removed FreeCAD 0.18.4, and installed 0.19 version

I was trying to do a Counter sunk Chamfer on a hole:

1. I tried to select the edge and then click on Counter Sunk Chamfer button. Its own parameter setting window will appear. But selected edge would not the ticked Counter Sunk Chamfer window. As soon as I click on the it to change any parameter, FreeCAD would hang.
2. Even if I select the part, then click on Counter Sunk Chamfer button. The screen will appear, but when I select the edge on the part, it would not be ticked in the Counter Sunk Chamfer. Then I try to click on it, the FreeCAD would hang.

I removed FreeCAD 0.19, and installed 0.18.4. Then added Fastener WB. It is working now. It means, the issue is between Fastener WB and FreeCAD 0.19.
User avatar
bambuko
Veteran
Posts: 2185
Joined: Thu Oct 24, 2019 12:53 pm
Location: UK, England, North Devon

Re: Fasteners workbench based on screw-maker

Post by bambuko »

Excellent workbench, but it has two limitations as far as my needs :oops:

1)
The smallest metric thread is M1.6
I need fasteners smaller than that, for example:
https://ghw-modellbau.de/index.php?cPat ... anguage=de
or even smaller:
https://ghw-modellbau.de/index.php?cPath=4_5_7_103

2)
I need "threaded rod for tapping holes" and "threaded tube for cutting external threads" in a range of ME threads:
https://www.gewinde-normen.de/en/me-thread.html


I had a go (as discussed in this thread: https://forum.freecadweb.org/viewtopic. ... 6&start=20)
and was able to add smaller metric threads, but I stumbled beyond that both on understanding the threads databases and how to add what I wanted.

I tried to seek help by raising an issue on Github:
https://github.com/shaise/FreeCAD_FastenersWB/issues/88

I am more than happy to do all the work with adding of the data, but need help to get going.
Is there anybody out there who can help, please?
I am using Link branch and Assembly3
you can also download ... and try it here
excellent Assembly3 tutorials here
Modeler
Posts: 43
Joined: Fri Feb 19, 2021 4:42 pm

Re: 1/4 bolt problem - Shape is not a shell

Post by Modeler »

This is a great add on. Very impressive. Thanks for all the work.

The imperial bolts have an issue with 1/4 type = ASMEB18.2.1.6 UNC Machine Screws. The other sizes seem to work correctly.


quarter-inch-bolt-problem.png
quarter-inch-bolt-problem.png (50.8 KiB) Viewed 2572 times


10:13:07 Traceback (most recent call last):
File "C:\Users\Colin\Downloads\FreeCAD-0.19.1.a88db11\Config\AppData\Roaming\FreeCAD\Mod\fasteners\FastenersCmd.py", line 160, in execute
s = screwMaker.createFastener(fp.type, d, l, threadType, True)
File "C:\Users\Colin\Downloads\FreeCAD-0.19.1.a88db11\Config\AppData\Roaming\FreeCAD\Mod\fasteners\ScrewMaker.py", line 338, in createFastener
return self.createScrew(type, diam, len, threadType, shapeOnly)
File "C:\Users\Colin\Downloads\FreeCAD-0.19.1.a88db11\Config\AppData\Roaming\FreeCAD\Mod\fasteners\screw_maker.py", line 941, in createScrew
screw = self.makeIso4017_2(ST_text, ND_text,l)
File "C:\Users\Colin\Downloads\FreeCAD-0.19.1.a88db11\Config\AppData\Roaming\FreeCAD\Mod\fasteners\screw_maker.py", line 1836, in makeIso4017_2
rthread = self.makeShellthread(dia, P, halfturns, True, offSet)
File "C:\Users\Colin\Downloads\FreeCAD-0.19.1.a88db11\Config\AppData\Roaming\FreeCAD\Mod\fasteners\screw_maker.py", line 3362, in makeShellthread
TheShell = Part.Shell(TheFaces)
<class 'Part.OCCError'>: Shape is not a shell


OS: Windows 10 Version 2009
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24276 (Git)
Build type: Release
Branch: releases/FreeCAD-0-19
Hash: a88db11e0a908f6e38f92bfc5187b13ebe470438
Python version: 3.8.6+
Qt version: 5.15.1
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/Canada (en_CA)
Syres
Veteran
Posts: 2899
Joined: Thu Aug 09, 2018 11:14 am

Re: 1/4 bolt problem - Shape is not a shell

Post by Syres »

Modeler wrote: Mon May 03, 2021 2:22 pm This is a great add on. Very impressive. Thanks for all the work.

The imperial bolts have an issue with 1/4 type = ASMEB18.2.1.6 UNC Machine Screws. The other sizes seem to work correctly.

OCC version: 7.5.0
It isn't an issue with the workbench as such, the specific screws work with thread = true using OCC 7.3.0 but don't using OCC 7.5.0


OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24267 (Git)
Build type: Release
Branch: master
Hash: b2ca86d8d72b636011a73394bf9bcdedb3b109b7
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)
Post Reply