Curves workbench

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
hammax
Posts: 804
Joined: Thu Jan 19, 2017 5:03 pm
Location: Ammersee

Re: Curves workbench

Postby hammax » Tue Mar 05, 2019 8:07 am

… concerning "ReflectLines" => I nearly understand:
The outmost contour line of a body, seen from a certain view direction.
Editable by DataTab.
(They sometimes disappear "into" the body???)

ReflLines.PNG
ReflLines.PNG (45.69 KiB) Viewed 424 times
User avatar
Chris_G
Posts: 1058
Joined: Tue Dec 31, 2013 4:10 pm
Location: France
Contact:

Re: Curves workbench

Postby Chris_G » Tue Mar 05, 2019 8:17 am

It just create a document object, from the shape function that Werner added recently.
I don't do any other treatment.
And I am not sure the UpDir and ViewPos properties have any influence on the result ???
freecad-heini-1
Posts: 5587
Joined: Tue Jan 07, 2014 11:10 am
Contact:

Re: Curves workbench

Postby freecad-heini-1 » Tue Mar 05, 2019 12:51 pm

Chris_G wrote:
Tue Mar 05, 2019 8:17 am
It just create a document object, from the shape function that Werner added recently.
I don't do any other treatment.
And I am not sure the UpDir and ViewPos properties have any influence on the result ???
Hi Chris,
great that this tool now has it's place in your curves-workbench.
But I'm sorry, something is wrong compared to what I tried with Werner original macro.
In the original macro I set the direction in vieport.

Please try it by yourself with my sample part:
https://forum.freecadweb.org/download/file.php?id=77500

Best regards
Wilfried
User avatar
Chris_G
Posts: 1058
Joined: Tue Dec 31, 2013 4:10 pm
Location: France
Contact:

Re: Curves workbench

Postby Chris_G » Tue Mar 05, 2019 1:47 pm

OK. Fixed.
The ReflectLines object is now created with current view direction.
If the tool is activated on an already existing ReflectLines object, it will update its ViewPos, ViewDir, and UpDir properties.
I added an icon too.
User avatar
saso
Posts: 1279
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Curves workbench

Postby saso » Tue Mar 05, 2019 1:59 pm

Woho, Chris you already did it! :) I was thinking to wait a bit longer so it would get tested a bit more before asking you if you would have interest to add it... Awesome! :)

You have added the options to the properties view, which I think is great and I was hopping you would do that in your implementation. However there is one more thing Werner did in his demo code, that is to pick an object (as you already do) or individual faces, and this has proved to be very useful. https://forum.freecadweb.org/viewtopic. ... 70#p289313

In the future I could maybe also find it nice if we would have the possibility to pick an element as an reference object for the view direction (ex. line, edge, axis of an coordinate system) :roll:
User avatar
Chris_G
Posts: 1058
Joined: Tue Dec 31, 2013 4:10 pm
Location: France
Contact:

Re: Curves workbench

Postby Chris_G » Tue Mar 05, 2019 2:49 pm

It should now work with individual faces.
User avatar
saso
Posts: 1279
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Curves workbench

Postby saso » Tue Mar 05, 2019 4:07 pm

Chris_G wrote:
Tue Mar 05, 2019 2:49 pm
It should now work with individual faces.
Thanks!
User avatar
GlouGlou
Posts: 1444
Joined: Sun Apr 05, 2015 9:02 am
Location: La Rochelle, France

Re: Curves workbench

Postby GlouGlou » Tue Mar 05, 2019 6:14 pm

IsoCurves error. The V curves are missing with this shape.
Attachments
V_missing.FCStd
(638.36 KiB) Downloaded 7 times
User avatar
GlouGlou
Posts: 1444
Joined: Sun Apr 05, 2015 9:02 am
Location: La Rochelle, France

Re: Curves workbench

Postby GlouGlou » Tue Mar 05, 2019 6:50 pm

CurvesOnSurface is not whole with this shape.
Attachments
C_NotFull.FCStd
(422.16 KiB) Downloaded 9 times
User avatar
GlouGlou
Posts: 1444
Joined: Sun Apr 05, 2015 9:02 am
Location: La Rochelle, France

Re: Curves workbench

Postby GlouGlou » Tue Mar 05, 2019 9:36 pm

I'm trying to make fillet, but CurveOnSurface should be extended to the end of his "mother" surface. Could be a future option?
Attachments
fillet.FCStd
(305.45 KiB) Downloaded 6 times
Capture.PNG
Capture.PNG (93.85 KiB) Viewed 263 times