Dev logs of Rebar Addon for FreeCAD - GSoC project

Contributions from the participants, questions and answers to their projects.
Discussions of proposals for upcoming events.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
regis
Posts: 725
Joined: Sun Jul 12, 2015 8:17 am
Contact:

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by regis »

amrit3701 wrote: Wed Aug 09, 2017 3:51 pm
amrit3701 wrote: Sat Aug 05, 2017 7:10 pm Hello everyone,

Here is my TODO task list which I will complete before final phase evaluation:
1. Complete circular stirrup (spiral) which Yorik posted it in his previous post in this thread.
2. Create wiki pages for all rebar shapes which I completed.
3. Add "Apply" button in all dialog boxes of rebar shapes.
4. Add user facility to give custom spacing when he/she creating rebar. Now user gives custom spacing after creating rebar with rebar tool.
5. Also, discuss with Yorik that can we add rebar tools as default FreeCAD feature.
Yeah! I have completed my 3rd task. Now, all rebar dialog boxes have "Apply" button.

applybutton.png

Thanks,
Amazing. By the way great freecad ninja party. :D
User avatar
saso
Veteran
Posts: 1924
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by saso »

amrit3701 wrote: Wed Aug 09, 2017 3:51 pm Yeah! I have completed my 3rd task. Now, all rebar dialog boxes have "Apply" button.
Great! But maybe having the "Ok" button on the left and "Apply" on the right is more common?
User avatar
regis
Posts: 725
Joined: Sun Jul 12, 2015 8:17 am
Contact:

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by regis »

saso wrote: Wed Aug 09, 2017 6:12 pm
amrit3701 wrote: Wed Aug 09, 2017 3:51 pm Yeah! I have completed my 3rd task. Now, all rebar dialog boxes have "Apply" button.
Great! But maybe having the "Ok" button on the left and "Apply" on the right is more common?
Lol sasso thats a menial difference.
User avatar
saso
Veteran
Posts: 1924
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by saso »

regis wrote: Wed Aug 09, 2017 6:41 pm Lol sasso thats a menial difference.
But important! 8-)
User avatar
regis
Posts: 725
Joined: Sun Jul 12, 2015 8:17 am
Contact:

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by regis »

saso wrote: Wed Aug 09, 2017 9:01 pm
regis wrote: Wed Aug 09, 2017 6:41 pm Lol sasso thats a menial difference.
But important! 8-)
elaborate on your reasoning, i'm curious as to what is your logic for saying it is important,
User avatar
saso
Veteran
Posts: 1924
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by saso »

Well anyway, it seems that this is actually done automatically based on the operating system someone uses :roll: It is looking as expected here.
User avatar
saso
Veteran
Posts: 1924
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by saso »

Here is one bug, probably for yorik, if using StraightRebar the vertical orientation will create wrong Centerline representation of the rebar, both if choosing it as a first option or if switching later from horizontal to vertical.

OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.11749 (Git)
Build type: Release
Branch: master
Hash: 6c4bdf24dfd697ee212ec5950969125851a0907c
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.1.0
Locale: Slovenian/Slovenia (sl_SI)
User avatar
regis
Posts: 725
Joined: Sun Jul 12, 2015 8:17 am
Contact:

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by regis »

saso wrote: Wed Aug 09, 2017 9:01 pm
regis wrote: Wed Aug 09, 2017 6:41 pm Lol sasso thats a menial difference.
But important! 8-)
I use to wonder why you have the 'cancel, apply, ok' trio combination in applications when validating and modifying inputs,
over the years i've convinced my self that cancel is needed by default, apply is perhaps when you are modifying some data, and it doesn't have have an auto generate preview, or realtime input modification preview of some sort, then you hit apply, it changes, then you say, i like it, hmm i don't like, change again, apply, etc, and then when you are staisfied you hit "ok", to validate the final option and to close out of the submenu.
But the strange thing in freecad is that you have the reload botton, and you have some part tools which when you hit apply the generate something like okay as well, so no difference, an then you have in the arch workbench, the section cut tool which when you modify something, not only does it not generate automatically, (maybe for the better because crazy complex calc which crash program at this point might make freecad unsable in the end, so it is best to have an option that tells the section plane, ok recompute new changes.
User avatar
amrit3701
Posts: 343
Joined: Mon Jun 13, 2016 5:37 pm

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by amrit3701 »

saso wrote: Wed Aug 09, 2017 9:40 pm Well anyway, it seems that this is actually done automatically based on the operating system someone uses :roll: It is looking as expected here.
Yes, it depends on operating system. I using Linux (Ubuntu) and it sorted buttons as per dictionary order (like according to the first alphabet). ;) May be we can set the order of standard buttons but at present, I don't know how.

Regards,
Amritpal Singh
Github, Like my work, sponsor me!
thschrader
Veteran
Posts: 3156
Joined: Sat May 20, 2017 12:06 pm
Location: Germany

Re: Dev logs of Rebar Addon for FreeCAD - GSoC project

Post by thschrader »

@amritpal/chakree:
please see
https://forum.freecadweb.org/viewtopic. ... 52#p186052

EDIT 10.08.17
Circular stirrup tool:
This happens when you use default parameters... :)
circular_stirrup.JPG
circular_stirrup.JPG (88.21 KiB) Viewed 1839 times
Post Reply