[Fixed] Bug #3281: STL object doesn't retain its rotation after change

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
Kunda1
Posts: 5505
Joined: Thu Jan 05, 2017 9:03 pm

[Fixed] Bug #3281: STL object doesn't retain its rotation after change

Postby Kunda1 » Wed Dec 06, 2017 6:18 pm

issue #3281: STL object doesn't retain its rotation after change
OP posted and bailed without uploading an example or saying what version of 0.17 they used. Can someone test this ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
DeepSOIC
Posts: 6963
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby DeepSOIC » Wed Dec 06, 2017 6:45 pm

I can confirm it on my rather old FC:
OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.12595 (Git)
Build type: Release
Branch: master
Hash: 8c7bb0cd551cf11551ff71d716a16211c6d5e13d
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.1.0
Locale: Russian/RussianFederation (ru_RU)

But I could only reproduce it after I had watched the video. The key is that Placement property is open in property editor while the placement is changed by transform widget. Then, changes in property editor cause some weirdness with angles.

I wonder if this PR fixes it: https://github.com/FreeCAD/FreeCAD/pull/1053
plgarcia
Posts: 281
Joined: Wed Jun 17, 2015 9:47 pm
Location: Near Paris (France)

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby plgarcia » Wed Dec 06, 2017 10:22 pm

I think the PR may solve at least partly this problem.
But it is not linked to the stl file but for any part, when the rotation leads to revert the rotation axis.
I will make some tests to give you more complete information.
Last edited by plgarcia on Fri Dec 08, 2017 12:32 pm, edited 1 time in total.
plgarcia
Posts: 281
Joined: Wed Jun 17, 2015 9:47 pm
Location: Near Paris (France)

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby plgarcia » Wed Dec 06, 2017 11:03 pm

What if you transform the Part. Then select another part and reselect the part before changing its placement.
As the pannel will be reloaded when switching parts, it will be resynchronized with the internal representation.
gitamani
Posts: 3
Joined: Thu Dec 07, 2017 12:41 am

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby gitamani » Thu Dec 07, 2017 1:00 am

I have duvuto inscivermi to the forum to be able to answer.
Keep in mind that I can not write English and use the translator.
I've been using Freecad for two years and I'm happy to collaborate.
Thank you

Giuseppe
plgarcia
Posts: 281
Joined: Wed Jun 17, 2015 9:47 pm
Location: Near Paris (France)

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby plgarcia » Thu Dec 07, 2017 10:31 am

Ok the time to recompile everything to make a test.
The PR 1053 solves the problem in all cases I have tested (composition on different axis, negative, positive angles etc.
Good news!

Nevertheless the manipulation I propose by selecting another part before moving the part again after the transform should work, so you can wait the PR is taken.
gitamani
Posts: 3
Joined: Thu Dec 07, 2017 12:41 am

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby gitamani » Thu Dec 07, 2017 10:10 pm

I had already found the solution in the way you indicated: select another object before changing the position.

Giuseppe
gitamani
Posts: 3
Joined: Thu Dec 07, 2017 12:41 am

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby gitamani » Sat Dec 09, 2017 12:48 am

On Version 0.17 Rev. 12772 2017/12/06it seems solved. The problem is no longer present.
Great.
Thank you

Giuseppe
User avatar
Kunda1
Posts: 5505
Joined: Thu Jan 05, 2017 9:03 pm

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby Kunda1 » Sat Dec 09, 2017 12:58 am

gitamani wrote:
Sat Dec 09, 2017 12:48 am
On Version 0.17 Rev. 12772 2017/12/06it seems solved. The problem is no longer present.
I'm confused...so you can't recreate on the latest 0.17 ? (current one as of this writing is 12798)
Or did you install build PR 1053 per @plgarcia and confirm that it fixes it?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
plgarcia
Posts: 281
Joined: Wed Jun 17, 2015 9:47 pm
Location: Near Paris (France)

Re: Bug #3281: STL object doesn't retain it's rotation after change

Postby plgarcia » Sat Dec 09, 2017 10:25 am

gitamani wrote:
Sat Dec 09, 2017 12:48 am
On Version 0.17 Rev. 12772 2017/12/06it seems solved. The problem is no longer present.
Great.
Thank you

Giuseppe
No the problem is still present in this vesion It happens only with certains angles (negatives angles).
But the PR 1053 solves it as confirmed by kunda1.

Now we have to wait for sombody to pull the PR in FreeCAD master.
Regards