Pauvres_honteux wrote: ↑Sun May 20, 2018 12:23 pm
abdullah wrote:ping
Hi abdullah, since realthunders work lives in a branch of his own I'd like to ask you once again to consider this feature request and invoking it in the Sketcher directly.
As long as we can get it out of the Sketcher some one else may take it from there.
I guess you are referring to the publishing of elements of a sketch, so this export commands realthunder has implemented.
There are several points:
1. I am not better in any way or otherwise hold more power than realthunder within FreeCAD. In fact realthunder appears to have way much more knowledge than me of computer science and general FreeCAD.
2. I hate to repeat work already done.
3. I have full deference for the implementations of my peer developers. I am not stealing code or otherwise interfering into their developments.
How I think this should be solved?
There must be a moment when realthunder shall decide whether his work is ready for a merge and whether he wants his work merged with FC or not.
If he wants to merge into master, and because his work is huge, he will have to bring Werner in to a thread and discuss with him how to do it. It may be that it has to be organised "into thematic review friendly merge packages". Because realthunder wrote his code, he should be in the best position to provide it in an "easy-to-review" form. Hopefully there won't be any no-go areas. But this all depends on how realthunder and Werner want to tackle the issue. That said, not that my help is required as we are talking about very capable people, but if help is needed then I am ready to assist wherever is needed.
