integration between ose-piping-workbench and flamingo-wb

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
rus
Posts: 73
Joined: Wed Feb 22, 2017 6:37 pm

Re: integration between ose-piping-workbench and flamingo-wb

Post by rus »

Geoplace wrote: Mon Apr 08, 2019 1:55 am I think that is best to focus to make it work with v0.18 with python 3 and Qt5 and make a note to say that it's not backwards compatible.

I read that V0.17 will not be supported by FreeCAD devolopers.
Joel_graff wrote: Mon Apr 08, 2019 2:37 am ...
I would agree with @GeoPlace. Support for both in v0.18 is simply to smooth the transition to Qt5 / Py3 only in 0.19. And 0.19 will probably be released in a year. Unless it's an easy thing to accommodate the older frameworks, I would just ignore them since there will be no reason to support them once 0.19 is released.
OK. Then I will focus on v0.18
Last edited by rus on Sat Apr 13, 2019 8:22 am, edited 1 time in total.
User avatar
rus
Posts: 73
Joined: Wed Feb 22, 2017 6:37 pm

Re: integration between ose-piping-workbench and flamingo-wb

Post by rus »

kisolre wrote: Mon Apr 08, 2019 6:57 pm I tried to install and run that workbench ut when I try to switch to if I get the following error:

Code: Select all

No module named 'Coupling'
Traceback (most recent call last):
  File "<string>", line 45, in Initialize
  File "C:\Users\Wivern\AppData\Roaming\FreeCAD\Mod\ose-piping-workbench\OsePipingCommands.py", line 28, in <module>
    import OsePiping.CouplingGui as CouplingGui
  File "C:\Users\Wivern\AppData\Roaming\FreeCAD\Mod\ose-piping-workbench\OsePiping\CouplingGui.py", line 6, in <module>
    import Coupling
There is a file OsePiping\Coupling.py but it is not found. Any ideas why is that?
I am already working on a fix.
User avatar
rus
Posts: 73
Joined: Wed Feb 22, 2017 6:37 pm

Re: integration between ose-piping-workbench and flamingo-wb

Post by rus »

I fixed a lot of imports. I hope now ose-piping WB will also work in windows.
kisolre
Veteran
Posts: 4164
Joined: Wed Nov 21, 2018 1:13 pm

Re: integration between ose-piping-workbench and flamingo-wb

Post by kisolre »

rus wrote: Sat Apr 13, 2019 9:13 am I fixed a lot of imports. I hope now ose-piping WB will also work in windows.
A quick test shows it is working. But here is another broken import:

Code: Select all

Init: Processing command line files
Traceback (most recent call last):
  File "C:\Users\Wivern\AppData\Roaming\FreeCAD\Mod\ose-piping-workbench\OsePiping\CreatePartGui.py", line 239, in accept
    self.acceptCreationMode()
  File "C:\Users\Wivern\AppData\Roaming\FreeCAD\Mod\ose-piping-workbench\OsePiping\CreatePartGui.py", line 210, in acceptCreationMode
    self.params.document, self.params.table, partName, outputType)
  File "C:\Users\Wivern\AppData\Roaming\FreeCAD\Mod\ose-piping-workbench\OsePiping\SweepElbowGui.py", line 31, in createNewPart
    part = builder.create(partName, outputType)
  File "C:\Users\Wivern\AppData\Roaming\FreeCAD\Mod\ose-piping-workbench\OsePiping\SweepElbow.py", line 317, in create
    import OsePiping.FlSweepElbow as FlSweepElbow
  File "C:\Users\Wivern\AppData\Roaming\FreeCAD\Mod\ose-piping-workbench\OsePiping\FlSweepElbow.py", line 9, in <module>
    import SweepElbow as SweepElbowMod
ModuleNotFoundError: No module named 'SweepElbow'

Code: Select all

OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16267 (Git)
Build type: Release
Branch: master
Hash: ddb335cfe057336f1958d68126bb0471328d735c
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Bulgarian/Bulgaria (bg_BG)
User avatar
rus
Posts: 73
Joined: Wed Feb 22, 2017 6:37 pm

Re: integration between ose-piping-workbench and flamingo-wb

Post by rus »

kisolre wrote: Sat Apr 13, 2019 11:20 am A quick test shows it is working. But here is another broken import:
...
Thank you for the bug report I fixed it. I just tests the WB under windows 10 it can create flamingo parts :D now !
User avatar
rus
Posts: 73
Joined: Wed Feb 22, 2017 6:37 pm

Re: integration between ose-piping-workbench and flamingo-wb

Post by rus »

I fixed two other bugs:
  • "I cannot place pipes into not-90° elbows.".
  • "Cannot place pipe and fittings into modified fittings.".
I think I need to learn how to do proper Visualization for pipe parts. All the connections are based on Ports. Here is the description https://wiki.opensourceecology.de/OSE_P ... ench_Ports
It is like a SnapPoints from Arch but with orientation (Rotation + orientation) in Arch https://www.freecadweb.org/wiki/Arch_Pipe/en

Maybe I should change the name to SnapPoint too? @Yorik what do you think?
yorik wrote: Wed Aug 24, 2016 2:30 pm
Post Reply