NormandC wrote: ↑Sat Jul 14, 2018 7:45 pm
I think this should be implemented ASAP in the freecad-daily PPA.
Definitely, will do.
One question: ulrich1a has been proposing to build the doc package in other languages, and made forays into creating a build script. Italian and French translations on the wiki are almost 100% complete. Hopefully further languages could be added once they reach a percentage completion threshold. Could you maybe factor this into your freecad-doc package, or is it too much for now? Does your repo contain the translations?
Although I answered this in Gitter, just leaving my response here for others. The repo doesn't contain the translations, but it does have the option to pull them. It'll take a while to run but it shouldn't be too difficult to include doc packages in other languages, and indeed that was one of my nice-to-have goals for this package. The internationalization/localization of software is one of my favorite things about FOSS, so kudos to all who have done translation work for the project, hopefully this will help more people get the benefit of all y'all's translation work.
Also, were you aware that Yorik backported in the past 3 weeks quite a few commits to the releases/0-17 branch? One merged yesterday is extremely important IMHO (by wandererfan) as it gives a hint about the PartDesign strict one-solid rule that never ceases to confuse users.
No, I wasn't... IMO we should consider tagging a point release, i.e. 0.17.1, which is better than 0.17.xxxxx, especially when "git commit xxxxx" is a bit misleading about what exactly is in this version of 0.17...
Since a new update of the freecad-stable PPA package will be needed (bringing it to v0.17.13528), I'm wondering if the freecad-doc split shouldn't be done before updating the package?
It isn't too necessary as we can do it just by updating the Debian revision numbers of the package.
kkremitzki wrote: ↑Fri Jul 13, 2018 10:31 amUnfortunately I had a hell of a time trying to get the PDF included.
I wasn't aware that a PDF was being built at compile time? Did you add this?
Also including the answer I gave on Gitter here for others... when compiling from source, the documentation files freecad.qch and freecad.qhc are included in src/Doc. These, however, were originally generated from scripts in src/Tools/offlinedoc. In addition to buildqhelp.py which builds the aforementioned 2 files, there's buildpdf.py which makes the PDF, but the built PDF is not included in our Git repo in the same way as freecad.qhc/qch.
BTW, I fixed the problem with the PDF builds. For some reason, having "localwiki/freecad.pdf" in debian/freecad-doc.install was not enough for the file to get included into the .deb, it only worked when that line was in debian/freecad-doc.docs. So, once all the translation files are done downloading, we will be able to have freecad-doc-fr, freecad-doc-it, freecad-doc-de, etc, packages!!!
Could you maybe update your repo's description based on this? I believe that it may exceed Debian rules for length, but the last sentence could be deleted I think.
The first paragraph could surely be streamlined. Maybe others will have suggestions to improve the description.
Definitely, I had noticed there was a difference in the descriptions but forgot to update them as well. As far as length, it may just require a shortening of some lines but the total amount of text should be fine.
